[GitHub] [activemq] cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…

[GitBox <gi...@apache.org>]

cshannon commented on a change in pull request #349: AMQ-7159 - Adding a new attribute on PersistenceAdapterViewMBean to s…
URL: https://github.com/apache/activemq/pull/349#discussion_r262898876
 
 

 ##########
 File path: activemq-broker/src/main/java/org/apache/activemq/broker/jmx/PersistenceAdapterView.java
 ##########
 @@ -64,11 +88,46 @@ private String invoke(Callable<String> callable) {
         return result;
     }
 
+    private String serializePersistenceAdapterStatistics() {
+        if (persistenceAdapterStatistics != null) {
+            try {
+                final ObjectMapper mapper = new ObjectMapper();
 
 Review comment:
   ObjectMapper is threadsafe so you should just create it one time for the class so we don't need to re-create it over and over.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services