[jira] [Updated] (FOP-2160) writing-mode="lr" causing null-pointer-exception

["Robert Meyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/FOP-2160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Meyer updated FOP-2160:
------------------------------

    Attachment: patch.diff

I had a quick look at this and found that the null pointer was happening because the adjustingInfo variable was not set. I am surprised this issue has not come up before as having gone through the debug process, it seems clear that this value may or may not be set. The AbstractTextArea.applyVariationFactor handles null whereas the same method in FilledArea does not. The reason why the null pointer is not occuring when you omit any of the three things you mentioned is because the applyVariations is not called which bypasses the issue. The patch simply allows the FilledArea class method to handle the null value.
                
> writing-mode="lr" causing null-pointer-exception
> ------------------------------------------------
>
>                 Key: FOP-2160
>                 URL: https://issues.apache.org/jira/browse/FOP-2160
>             Project: Fop
>          Issue Type: Bug
>          Components: page-master/layout
>    Affects Versions: 1.1
>         Environment: Operating System: All
> Platform: All
>            Reporter: james quest
>         Attachments: patch.diff, stack
>
>
> i have seen that this fo causes a null-pointer-exception at fop1.1rc1.
> the same fo is perfectly fine if writing-mode="lr" or not specified
> <fo:root xmlns:fo="http://www.w3.org/1999/XSL/Format" font-family="Arial" writing-mode="rl">
>   <fo:layout-master-set>
>     <fo:simple-page-master page-height="297mm" page-width="210mm" master-name="a4">
>       <fo:region-body margin-top="11mm" margin-bottom="12mm" margin-right="10mm" margin-left="10mm"/>
>     </fo:simple-page-master>
>   </fo:layout-master-set>
>   <fo:page-sequence master-reference="a4">
>     <fo:flow flow-name="xsl-region-body">
>       <fo:block id="1">وكلما</fo:block>
>       <fo:block text-align-last="justify">More text <fo:leader leader-pattern="dots"/> <fo:page-number-citation ref-id="1"/>
>       </fo:block>
>     </fo:flow>
>   </fo:page-sequence>
> </fo:root>
> attached is the stack trace. 
> if you remove *any* of these 3 things, then there is no issue either 
> 1. <fo:leader>
> 2. <fo:page-number-citation>
> 3. text-align-last="justify"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira