You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/01/17 18:29:32 UTC
[GitHub] [incubator-mxnet] leezu commented on a change in pull request
#17336: [BUGFIX] fix model zoo parallel download
leezu commented on a change in pull request #17336: [BUGFIX] fix model zoo parallel download
URL: https://github.com/apache/incubator-mxnet/pull/17336#discussion_r368075286
##########
File path: python/mxnet/gluon/model_zoo/model_store.py
##########
@@ -103,16 +106,16 @@ def get_model_file(name, root=os.path.join(base.data_dir(), 'models')):
util.makedirs(root)
- zip_file_path = os.path.join(root, file_name+'.zip')
+ temp_zip_file_path = os.path.join(root, file_name+random_uuid+'.zip')
Review comment:
I believe tempfile is typically on a different filesystem, so there is no atomic rename operation to the target directory and filename available.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services