You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by shen guoquan <gu...@intel.com> on 2015/03/05 03:33:21 UTC
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 5, 2015, 2:33 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs
-----
pom.xml 4c80916
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:21 a.m., Colin Ma wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 28
> > <https://reviews.apache.org/r/31575/diff/1/?file=881538#file881538line28>
> >
> > if user has write permission, but he still need read permission to read data?
Currently, yes. The user need the read permission to read data
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:21 a.m., Colin Ma wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 28
> > <https://reviews.apache.org/r/31575/diff/1/?file=881538#file881538line28>
> >
> > if user has write permission, but he still need read permission to read data?
Currently, yes. The user need the read permission to read data
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
<https://reviews.apache.org/r/31575/#comment122264>
if user has write permission, but he still need read permission to read data?
- Colin Ma
On March 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:45 a.m., Xiaomeng Huang wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java, line 21
> > <https://reviews.apache.org/r/31575/diff/1/?file=881540#file881540line21>
> >
> > why do define this abstract class?
> > I think we just need to follow current sentry's code style.
> > It means Job implements SqoopAuthorizable
Thanks for your advice. I will fix it.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75288
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 5, 2015, 3:45 a.m., Xiaomeng Huang wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java, line 21
> > <https://reviews.apache.org/r/31575/diff/1/?file=881540#file881540line21>
> >
> > why do define this abstract class?
> > I think we just need to follow current sentry's code style.
> > It means Job implements SqoopAuthorizable
Thanks for your advice. I will fix it.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75288
-----------------------------------------------------------
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75288
-----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java
<https://reviews.apache.org/r/31575/#comment122267>
why do define this abstract class?
I think we just need to follow current sentry's code style.
It means Job implements SqoopAuthorizable
- Xiaomeng Huang
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 6:13 a.m., Prasad Mujumdar wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 30
> > <https://reviews.apache.org/r/31575/diff/3/?file=897636#file897636line30>
> >
> > Nit: ALL=READ|WRITE instead of hardcodeing 3
>
> shen guoquan wrote:
> Good advice. I will fix it. Thanks Prasad
By the way. Could you help me mark +1 on the SENTRY-645. Thanks for your help, Prasad :)
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
On 三月 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 6:13 a.m., Prasad Mujumdar wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 30
> > <https://reviews.apache.org/r/31575/diff/3/?file=897636#file897636line30>
> >
> > Nit: ALL=READ|WRITE instead of hardcodeing 3
Good advice. I will fix it. Thanks Prasad
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
On 三月 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 6:13 a.m., Prasad Mujumdar wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 30
> > <https://reviews.apache.org/r/31575/diff/3/?file=897636#file897636line30>
> >
> > Nit: ALL=READ|WRITE instead of hardcodeing 3
Good advice. I will fix it. Thanks Prasad
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
On 三月 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 6:13 a.m., Prasad Mujumdar wrote:
> > sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java, line 30
> > <https://reviews.apache.org/r/31575/diff/3/?file=897636#file897636line30>
> >
> > Nit: ALL=READ|WRITE instead of hardcodeing 3
>
> shen guoquan wrote:
> Good advice. I will fix it. Thanks Prasad
By the way. Could you help me mark +1 on the SENTRY-645. Thanks for your help, Prasad :)
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
On 三月 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
Ship it!
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
<https://reviews.apache.org/r/31575/#comment125244>
Nit: ALL=READ|WRITE instead of hardcodeing 3
- Prasad Mujumdar
On March 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 24, 2015, 5:58 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 48b84d2
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review77333
-----------------------------------------------------------
Ship it!
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
<https://reviews.apache.org/r/31575/#comment125244>
Nit: ALL=READ|WRITE instead of hardcodeing 3
- Prasad Mujumdar
On March 17, 2015, 8:50 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated March 17, 2015, 8:50 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 24, 2015, 5:58 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 48b84d2
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 17, 2015, 8:50 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 4c80916
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 17, 2015, 8:50 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 4c80916
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 9, 2015, 3:08 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 4c80916
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/
-----------------------------------------------------------
(Updated 三月 9, 2015, 3:08 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
Diffs (updated)
-----
pom.xml 4c80916
sentry-core/pom.xml 1552133
sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
sentry-dist/pom.xml f63b33b
Diff: https://reviews.apache.org/r/31575/diff/
Testing
-------
Ran included unit tests.
Thanks,
shen guoquan
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Colin Ma <ju...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75282
-----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java
<https://reviews.apache.org/r/31575/#comment122264>
if user has write permission, but he still need read permission to read data?
- Colin Ma
On March 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31575: SENTRY-645: Add sqoop authorizable model for
sentry authorization
Posted by Xiaomeng Huang <xi...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31575/#review75288
-----------------------------------------------------------
sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java
<https://reviews.apache.org/r/31575/#comment122267>
why do define this abstract class?
I think we just need to follow current sentry's code style.
It means Job implements SqoopAuthorizable
- Xiaomeng Huang
On 三月 5, 2015, 2:33 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31575/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:33 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Add the authorizable model in Sentry for Sqoop role-based authorizaiton integration
>
>
> Diffs
> -----
>
> pom.xml 4c80916
> sentry-core/pom.xml 1552133
> sentry-core/sentry-core-model-sqoop/pom.xml PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Connector.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Job.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Link.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/Server.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionConstant.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopActionFactory.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/main/java/org/apache/sentry/core/model/sqoop/SqoopBaseAuthorizable.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAction.java PRE-CREATION
> sentry-core/sentry-core-model-sqoop/src/test/java/org/apache/sentry/core/model/sqoop/TestSqoopAuthorizable.java PRE-CREATION
> sentry-dist/pom.xml f63b33b
>
> Diff: https://reviews.apache.org/r/31575/diff/
>
>
> Testing
> -------
>
> Ran included unit tests.
>
>
> Thanks,
>
> shen guoquan
>
>