You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/01/29 21:49:27 UTC
[GitHub] [avro] jacobtolar opened a new pull request #1074: AVRO-2817: Do not validate schema defaults in file
jacobtolar opened a new pull request #1074:
URL: https://github.com/apache/avro/pull/1074
* AVRO-2817: Do not validate schema defaults in file.
* AVRO-2817: Add missing imports
(cherry picked from commit afcf861d6356ef27d09fa2c81083934a9de9296b)
This is a cherry-pick of #966 backporting the change to the 1.9.x branch.
----
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-2817
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
* Unit test added by @RyanSkraba cherry-picked here.
### Commits
- [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
Commit message generated by `git cherry-pick -x afcf861d6356ef27d09fa2c81083934a9de9296b`.
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] jacobtolar edited a comment on pull request #1074: AVRO-2817: Do not validate schema defaults in file
Posted by GitBox <gi...@apache.org>.
jacobtolar edited a comment on pull request #1074:
URL: https://github.com/apache/avro/pull/1074#issuecomment-770069444
Per my comment on https://issues.apache.org/jira/browse/AVRO-2817 , this backports the fix in #966 to 1.9.x branch.
I'm not sure if there will be a 1.9.3 release, but if there is, it would be nice to include this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] jacobtolar commented on pull request #1074: AVRO-2817: Do not validate schema defaults in file
Posted by GitBox <gi...@apache.org>.
jacobtolar commented on pull request #1074:
URL: https://github.com/apache/avro/pull/1074#issuecomment-770069444
Per my comment on https://issues.apache.org/jira/browse/AVRO-2817 , this backports the fix in #966 to 1.9.x branch.
I'm not sure if there will be a 1.9.3 release but if there is, it would be nice to include this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org