[GitHub] [camel] davsclaus commented on a diff in pull request #7577: Add doc for kafka transaction

[GitBox <gi...@apache.org>]

davsclaus commented on code in PR #7577:
URL: https://github.com/apache/camel/pull/7577#discussion_r868805302


##########
components/camel-kafka/src/main/docs/kafka-component.adoc:
##########
@@ -423,5 +423,16 @@ from("kafka:my_topic?headerFilterStrategy=#myStrategy")
 
 `myStrategy` object should be subclass of `HeaderFilterStrategy` and must be placed in the Camel registry, either manually or by registration as a bean in Spring/Blueprint, as it is `CamelContext` aware.
 
+== Kafka Transaction
+
+It needs to add `transactional.id`, `enable.idempotence` and `retries` in `additional-properties` to enable kafka transaction with the producer.
+[source,java]
+----
+from("direct:transaction")
+.to("kafka:my_topic?additional-properties[transactional.id]=1234additional-properties[enable.idempotence]=trueadditional-properties[retries]=5");

Review Comment:
   You need & to separate the options



##########
components/camel-kafka/src/main/docs/kafka-component.adoc:
##########
@@ -423,5 +423,16 @@ from("kafka:my_topic?headerFilterStrategy=#myStrategy")
 
 `myStrategy` object should be subclass of `HeaderFilterStrategy` and must be placed in the Camel registry, either manually or by registration as a bean in Spring/Blueprint, as it is `CamelContext` aware.
 
+== Kafka Transaction
+
+It needs to add `transactional.id`, `enable.idempotence` and `retries` in `additional-properties` to enable kafka transaction with the producer.

Review Comment:
   It needs -> You need



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org