You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org> on 2011/11/01 08:24:33 UTC
[jira] [Commented] (SQOOP-374) Migrate tool and orm packages to new
name space
[ https://issues.apache.org/jira/browse/SQOOP-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140994#comment-13140994 ]
jiraposter@reviews.apache.org commented on SQOOP-374:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2574/#review2978
-----------------------------------------------------------
Ship it!
+1. Thanks!
- Bilung
On 2011-10-29 08:37:37, Jarek Jarcec wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2574/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-29 08:37:37)
bq.
bq.
bq. Review request for Sqoop and Bilung Lee.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Please check whether this is something that we're looking for.
bq.
bq. Just let me firstly explain the weirdness in inheritance between com.cloudera.sqoop.tool.(Base)SqoopTool and org.apache.sqoop.tool.(Base)SqoopTool (and other children). I initially followed specification in master JIRA, but I've end up with not backward compatible code that I have to fix on several places to get it compiled. Problem was in broken inheritance topology - in old com.cloudera.sqoop package there was main parent SqoopTool with child BaseSqoopTool and additional children (ImportTool for example). With my original changes, ImportTool was no longer child of com.cloudera.sqoop.tool.(Base)SqoopTool because it was child of org.apache.sqoop.tool.(Base)SqoopTool instead. I wasn't able to find better solution for this problem than having this weird inheritance in place.
bq.
bq. If you have better idea how to get the job done, please don't hesitate to advise.
bq.
bq. Jarcec
bq.
bq.
bq. This addresses bug SQOOP-374.
bq. https://issues.apache.org/jira/browse/SQOOP-374
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /src/java/com/cloudera/sqoop/orm/AvroSchemaGenerator.java 1190173
bq. /src/java/com/cloudera/sqoop/orm/ClassWriter.java 1190173
bq. /src/java/com/cloudera/sqoop/orm/CompilationManager.java 1190173
bq. /src/java/com/cloudera/sqoop/orm/TableClassName.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/BaseSqoopTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/CodeGenTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/CreateHiveTableTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/EvalSqlTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ExportTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/HelpTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ImportAllTablesTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ImportTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/JobTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ListDatabasesTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ListTablesTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/MergeTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/MetastoreTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/SqoopTool.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ToolDesc.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/ToolPlugin.java 1190173
bq. /src/java/com/cloudera/sqoop/tool/VersionTool.java 1190173
bq. /src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java PRE-CREATION
bq. /src/java/org/apache/sqoop/orm/ClassWriter.java PRE-CREATION
bq. /src/java/org/apache/sqoop/orm/CompilationManager.java PRE-CREATION
bq. /src/java/org/apache/sqoop/orm/TableClassName.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/BaseSqoopTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/CodeGenTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/CreateHiveTableTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/EvalSqlTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ExportTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/HelpTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ImportAllTablesTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ImportTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/JobTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ListDatabasesTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ListTablesTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/MergeTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/MetastoreTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/SqoopTool.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ToolDesc.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/ToolPlugin.java PRE-CREATION
bq. /src/java/org/apache/sqoop/tool/VersionTool.java PRE-CREATION
bq. /src/test/com/cloudera/sqoop/orm/TestClassWriter.java 1190173
bq. /src/test/com/cloudera/sqoop/orm/TestParseMethods.java 1190173
bq. /src/test/com/cloudera/sqoop/tool/TestToolPlugin.java 1190173
bq.
bq. Diff: https://reviews.apache.org/r/2574/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Jarek
bq.
bq.
> Migrate tool and orm packages to new name space
> -----------------------------------------------
>
> Key: SQOOP-374
> URL: https://issues.apache.org/jira/browse/SQOOP-374
> Project: Sqoop
> Issue Type: Sub-task
> Reporter: Bilung Lee
> Assignee: Jarek Jarcec Cecho
>
> Refer to SQOOP-371 for details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira