You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "hanmz (via GitHub)" <gi...@apache.org> on 2024/05/22 04:07:45 UTC
[PR] [fix][broker] The result is inaccurate when schema is non-recoverable in method trimDeletedSchemaAndGetList. [pulsar]
hanmz opened a new pull request, #22758:
URL: https://github.com/apache/pulsar/pull/22758
### Motivation
The return secheamResult is inaccurate when schema encounter an non-recoverable exception in method `trimDeletedSchemaAndGetList`.
Although, we executed the `trimDeletedSchemaAndGetList` method at line 563, however the returned result is not used. We finally still returned `list` at line 568 `schemaResult.complete(list)`
### Modifications
Replace `list` with the method `trimDeletedSchemaAndGetList` result.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][broker] The result is inaccurate when schema is non-recoverable in method trimDeletedSchemaAndGetList. [pulsar]
Posted by "hanmz (via GitHub)" <gi...@apache.org>.
hanmz closed pull request #22758: [fix][broker] The result is inaccurate when schema is non-recoverable in method trimDeletedSchemaAndGetList.
URL: https://github.com/apache/pulsar/pull/22758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org