[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10739: [Optimization]Optimize some details of MLFlow task plugin #10740

[GitBox <gi...@apache.org>]

zhongjiajie commented on code in PR #10739:
URL: https://github.com/apache/dolphinscheduler/pull/10739#discussion_r912862838


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-mlflow/src/main/java/org/apache/dolphinscheduler/plugin/task/mlflow/MlflowParameters.java:
##########
@@ -286,4 +286,14 @@ public String getContainerName(){
         return containerName;
     }
 
+    public boolean getIsDeployDocker(){
+        boolean flag = false;
+        if (deployType.equals(MlflowConstants.MLFLOW_MODELS_DEPLOY_TYPE_DOCKER)) {
+            flag = true;
+        }else if (deployType.equals(MlflowConstants.MLFLOW_MODELS_DEPLOY_TYPE_DOCKER_COMPOSE)){
+            flag = true;
+        }
+        return flag;

Review Comment:
   ```suggestion
           return deployType.equals(MlflowConstants.MLFLOW_MODELS_DEPLOY_TYPE_DOCKER) || deployType.equals(MlflowConstants.MLFLOW_MODELS_DEPLOY_TYPE_DOCKER_COMPOSE);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org