You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "heronshoes (via GitHub)" <gi...@apache.org> on 2023/04/05 07:24:08 UTC
[GitHub] [arrow] heronshoes opened a new pull request, #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
heronshoes opened a new pull request, #34902:
URL: https://github.com/apache/arrow/pull/34902
### Rationale for this change
C GLib supported `MatchSubstringOptions` in #34725. This PR will use this and will supply an easy to use API in Ruby binding.
### What changes are included in this PR?
- Add a class `Arrow::Slicer::MatchSubstringCondition`
- Add a method `#match_substring` in `Arrow::Slicer::ColumnCondition`
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160288148
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
I see. I will open an issue and PR for it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160263239
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
FYI: The following change will work for it:
```diff
diff --git a/ruby/red-arrow/lib/arrow/table.rb b/ruby/red-arrow/lib/arrow/table.rb
index a14bf90d1f..da79e94b18 100644
--- a/ruby/red-arrow/lib/arrow/table.rb
+++ b/ruby/red-arrow/lib/arrow/table.rb
@@ -316,8 +316,6 @@ module Arrow
end
end
- filter_options = Arrow::FilterOptions.new
- filter_options.null_selection_behavior = :emit_null
sliced_tables = []
slicers.each do |slicer|
slicer = slicer.evaluate if slicer.respond_to?(:evaluate)
@@ -339,7 +337,7 @@ module Arrow
to += n_rows if to < 0
sliced_tables << slice_by_range(from, to)
when ::Array, BooleanArray, ChunkedArray
- sliced_tables << filter(slicer, filter_options)
+ sliced_tables << filter(slicer)
else
message = "slicer must be Integer, Range, (from, to), " +
"Arrow::ChunkedArray of Arrow::BooleanArray, " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on PR #34902:
URL: https://github.com/apache/arrow/pull/34902#issuecomment-1497419392
@kou Thanks! I tried to fix them.
Is it necessary to support '!match_substring' ?
(Such as `!slicer.string.match_substring("abc")`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #34902:
URL: https://github.com/apache/arrow/pull/34902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1159039407
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
+ string: ["array", "Arrow", "carrot", nil, "window"]
+ )
+ end
+
+ test("match_substring") do
+ sliced_table = @string_table.slice do |slicer|
+ slicer.string.match_substring("arr")
+ end
+ assert_equal(<<~TABLE, sliced_table.to_s)
+ index string
+0 1 array
+1 3 carrot
+2 (null) (null)
+ TABLE
+ end
+
+ test("match_substring with ignore_case option") do
Review Comment:
Could you use simple Ruby syntax like test name instead of English?
I like the style because it's easy to read for me :-)
```suggestion
test("match_substring(ignore_case:)") do
```
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
Why do we need this?
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -351,5 +356,22 @@ def evaluate
BooleanArray.new(raw_array)
end
end
+
+ class MatchSubstringFamilyCondition < Condition
+ def initialize(function, column, substring, ignore_case)
+ @function = function
+ @column = column
+ @options = MatchSubstringOptions.new
+ @options.pattern = substring
+ @options.ignore_case = ignore_case
+ end
+
+ def evaluate
+ case @function
+ when "match_substring"
+ Function.find("match_substring").execute([@column.data], @options).value
+ end
Review Comment:
```suggestion
Function.find(@function).execute([@column.data], @options).value
```
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
Review Comment:
I think that `string_` is redundant. Because we process only string in this context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1159244818
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -351,5 +356,22 @@ def evaluate
BooleanArray.new(raw_array)
end
end
+
+ class MatchSubstringFamilyCondition < Condition
+ def initialize(function, column, substring, ignore_case)
+ @function = function
+ @column = column
+ @options = MatchSubstringOptions.new
+ @options.pattern = substring
+ @options.ignore_case = ignore_case
+ end
+
+ def evaluate
+ case @function
+ when "match_substring"
+ Function.find("match_substring").execute([@column.data], @options).value
+ end
Review Comment:
Thanks, I will do so. (May some change needed to implement `#!@` or other family methods.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160261094
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -162,6 +162,11 @@ def select(&block)
def reject(&block)
RejectCondition.new(@column, block)
end
+
+ def match_substring(substring, ignore_case: false)
+ MatchSubstringCondition.new("match_substring",
Review Comment:
How about `MatchSubstringFamilyCondition` because this is not only for `match_substring`?
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -351,5 +356,33 @@ def evaluate
BooleanArray.new(raw_array)
end
end
+
+ class MatchSubstringCondition < Condition
+ def initialize(function, column, pattern, ignore_case, invert: false)
+ @function = function
+ @column = column
+ @options = MatchSubstringOptions.new
+ @options.pattern = pattern
+ @options.ignore_case = ignore_case
+ @invert = invert
+ end
+
+ def !@
+ MatchSubstringCondition.new(@function,
+ @column,
+ @options.pattern,
+ @options.ignore_case?,
+ invert: !@invert)
+ end
+
+ def evaluate
+ datum = Function.find(@function).execute([@column.data], @options)
+ if @invert
+ Function.find("invert").execute([datum]).value
+ else
+ datum.value
+ end
Review Comment:
It's not a strong opinion but the following may be simpler:
```suggestion
if @invert
datum = Function.find("invert").execute([datum])
end
datum.value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160338723
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -162,6 +162,11 @@ def select(&block)
def reject(&block)
RejectCondition.new(@column, block)
end
+
+ def match_substring(substring, ignore_case: false)
+ MatchSubstringFamilyCondition.new("match_substring",
+ @column, substring, ignore_case)
Review Comment:
```suggestion
@column, substring, ignore_case)
```
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -351,5 +356,32 @@ def evaluate
BooleanArray.new(raw_array)
end
end
+
+ class MatchSubstringFamilyCondition < Condition
+ def initialize(function, column, pattern, ignore_case, invert: false)
+ @function = function
+ @column = column
+ @options = MatchSubstringOptions.new
+ @options.pattern = pattern
+ @options.ignore_case = ignore_case
+ @invert = invert
+ end
+
+ def !@
+ MatchSubstringFamilyCondition.new(@function,
+ @column,
+ @options.pattern,
+ @options.ignore_case?,
+ invert: !@invert)
Review Comment:
```suggestion
@column,
@options.pattern,
@options.ignore_case?,
invert: !@invert)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1159240251
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
Review Comment:
Sure, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34902:
URL: https://github.com/apache/arrow/pull/34902#issuecomment-1497040812
:warning: GitHub issue #34819 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1158175613
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +488,29 @@ def setup
7 256 true
TABLE
end
+
+ test("match_substring") do
Review Comment:
Could you create sub test case and move `@string_table = ...` to here?
```ruby
sub_test_case("#match_substring") do
def setup
super # Not needed?
# index: is needed?
@table = Arrow::Table.new(index: [*1..5], string: ["array", "Arrow", "carrot", nil, "window"])
end
test("String") do
end
test("String, ignore_case:") do
end
end
```
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -351,5 +355,18 @@ def evaluate
BooleanArray.new(raw_array)
end
end
+
+ class MatchSubstringCondition < Condition
+ def initialize(column, substring, ignore_case)
+ @column = column
+ @options = MatchSubstringOptions.new
+ @options.pattern = substring
+ @options.ignore_case = true if ignore_case
Review Comment:
```suggestion
@options.ignore_case = ignore_case
```
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -162,6 +162,10 @@ def select(&block)
def reject(&block)
RejectCondition.new(@column, block)
end
+
+ def match_substring(substring, ignore_case: false)
+ MatchSubstringCondition.new(@column, substring, ignore_case)
Review Comment:
How about making this reusable for other `match_substring` family functions?
```suggestion
MatchSubstringFamilyCondition.new("match_substring", @column, substring, ignore_case)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1158421929
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +488,29 @@ def setup
7 256 true
TABLE
end
+
+ test("match_substring") do
Review Comment:
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #34902:
URL: https://github.com/apache/arrow/pull/34902#issuecomment-1497040762
* Closes: #34819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #34902:
URL: https://github.com/apache/arrow/pull/34902#issuecomment-1500563262
Benchmark runs are scheduled for baseline = 392dfe404a4c042ed86a4878a163441f969e3321 and contender = 35ef0fddb3cadea142729c9fbf10fe806f61af90. 35ef0fddb3cadea142729c9fbf10fe806f61af90 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/67741ec9da6e4be49c72500ce63ba286...ad7a8e155c144772b461bb6151893a2b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/af077170e8694f58927a5268666b3427...9da8d1cea87741bcaa157660a84d1448/)
[Finished :arrow_down:0.26% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/de179c5a2b6f43ddb3c06f825bc63556...8f5ed7bb2f7d46ab81530d9995cdff2c/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5316a74127f14c9eb77b5390776b98ed...f29de929f4854e039b25f439dcfde95d/)
Buildkite builds:
[Finished] [`35ef0fdd` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2649)
[Failed] [`35ef0fdd` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2682)
[Finished] [`35ef0fdd` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2647)
[Failed] [`35ef0fdd` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2673)
[Finished] [`392dfe40` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2648)
[Failed] [`392dfe40` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2681)
[Finished] [`392dfe40` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2646)
[Failed] [`392dfe40` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2672)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160288518
##########
ruby/red-arrow/lib/arrow/slicer.rb:
##########
@@ -162,6 +162,11 @@ def select(&block)
def reject(&block)
RejectCondition.new(@column, block)
end
+
+ def match_substring(substring, ignore_case: false)
+ MatchSubstringCondition.new("match_substring",
Review Comment:
Thnaks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1159243990
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
Yes it's redundant. I feel something strange for the behavior of propagating nulls to other columns, so I put it here to show as example for users. But I will remove `:index` column here.
May be off topic of this PR, is it useful to propagate nulls in slicer?
I prefer to same behavior of `table#filter(boolean_array)` or `slicer.select { |value| .. }`.
(Null is not selected.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on a diff in pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #34902:
URL: https://github.com/apache/arrow/pull/34902#discussion_r1160260699
##########
ruby/red-arrow/test/test-slicer.rb:
##########
@@ -484,4 +484,38 @@ def setup
7 256 true
TABLE
end
+
+ sub_test_case "MatchSubstringOptions family" do
+ def setup
+ @string_table = Arrow::Table.new(
+ index: [*1..5],
Review Comment:
It's just for keeping backward compatibility.
See also: #6732
But we may can change it for 12.0.0. (2023-04-11 is code freeze date: https://lists.apache.org/thread/wj2x50s2xyghnjm0pm4gt7yq5187zhwy )
Could you open an issue and a pull request for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] heronshoes commented on pull request #34902: GH-34819: [Ruby] Add Slicer::ColumnCondition#match_substring
Posted by "heronshoes (via GitHub)" <gi...@apache.org>.
heronshoes commented on PR #34902:
URL: https://github.com/apache/arrow/pull/34902#issuecomment-1499855147
Thanks for your support!
I will open issue/PR of its family.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org