[jira] [Commented] (DAFFODIL-1893) TDML Runner not caching schema compiles - only caches schemas if compileAllTopLevel is true

["Dave Thompson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DAFFODIL-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431093#comment-16431093 ] 

Dave Thompson commented on DAFFODIL-1893:
-----------------------------------------

Pulled the latest updates from the incubator-daffodil repository and verified the updates included the specified commit, 836d657ca5bd99577110e8c30007591a26ee4317.

Talked with Steve L about how to verify and he said that he had checked the performance during previous review and verified that performance for tests with long schema compile has improved.

> TDML Runner not caching schema compiles - only caches schemas if compileAllTopLevel is true
> -------------------------------------------------------------------------------------------
>
>                 Key: DAFFODIL-1893
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-1893
>             Project: Daffodil
>          Issue Type: Bug
>          Components: TDML Runner
>    Affects Versions: 2.0.0
>            Reporter: Michael Beckerle
>            Assignee: Dave Thompson
>            Priority: Major
>             Fix For: 2.1.0
>
>
> The TDML runner is supposed to cache compiled schemas so that many tests using the same DFDL schema will compile it only once.
> It currently only does this when compileAllTopLevel is true, but the default for this is false.
> The cache should be modified to take the root element into account - i.e., compile all top levels need not be true. The cache should hit, avoiding recompilation, so long as the same root element is being used. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)