You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/02/28 12:55:24 UTC
Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jan Schlicht.
Bugs: MESOS-8388
https://issues.apache.org/jira/browse/MESOS-8388
Repository: mesos
Description
-------
Displayed resource provider resources in GET_AGENTS response.
Diffs
-----
include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e
src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
Diff: https://reviews.apache.org/r/65833/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199163
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['65589', '65590', '65591', '65673', '65674', '65832', '65833']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833
Relevant logs:
- [libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833/logs/libprocess-tests-stdout.log):
```
[ RUN ] TimeTest.Output
[ OK ] TimeTest.Output (0 ms)
[----------] 4 tests from TimeTest (5 ms total)
[----------] 3 tests from TimeSeriesTest
[ RUN ] TimeSeriesTest.Set
[ OK ] TimeSeriesTest.Set (0 ms)
[ RUN ] TimeSeriesTest.Sparsify
[ OK ] TimeSeriesTest.Sparsify (1 ms)
[ RUN ] TimeSeriesTest.Truncate
[ OK ] TimeSeriesTest.Truncate (2 ms)
[----------] 3 tests from TimeSeriesTest (7 ms total)
[----------] 3 tests from JWTTest
[ RUN ] JWTTest.Parse
[ OK ] JWTTest.Parse (8 ms)
[ RUN ] JWTTest.Create
[ OK ] JWTTest.Create (1 ms)
[ RUN ] JWTTest.Stringify
[ OK ] JWTTest.Stringify (1 ms)
[----------] 3 tests from JWTTest (14 ms total)
[----------] 1 test from SSL
[ RUN ] SSL.Disabled
[ OK ] SSL.Disabled (10 ms)
[----------] 1 test from SSL (11 ms total)
[----------] 17 tests from SSLTest
[ RUN ] SSLTest.SSLSocket
```
- [libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833/logs/libprocess-tests-stderr.log):
```
ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833/logs/mesos-tests-stdout.log):
```
[ OK ] ContentType/SchedulerTest.Revive/1 (245 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/0
[ OK ] ContentType/SchedulerTest.Suppress/0 (251 ms)
[ RUN ] ContentType/SchedulerTest.Suppress/1
[ OK ] ContentType/SchedulerTest.Suppress/1 (261 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/0 (259 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersWithAllRolesSuppressed/1 (265 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/0 (327 ms)
[ RUN ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1
[ OK ] ContentType/SchedulerTest.NoOffersOnReregistrationWithAllRolesSuppressed/1 (320 ms)
[ RUN ] ContentType/SchedulerTest.Message/0
[ OK ] ContentType/SchedulerTest.Message/0 (319 ms)
[ RUN ] ContentType/SchedulerTest.Message/1
[ OK ] ContentType/SchedulerTest.Message/1 (341 ms)
[ RUN ] ContentType/SchedulerTest.Request/0
[ OK ] ContentType/SchedulerTest.Request/0 (105 ms)
[ RUN ] ContentType/SchedulerTest.Request/1
[ OK ] ContentType/SchedulerTest.Request/1 (111 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/0
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (82 ms)
[ RUN ] ContentType/SchedulerTest.SchedulerReconnect/1
[ OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (83 ms)
[----------] 32 tests from ContentType/SchedulerTest (17718 ms total)
[----------] 4 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
```
- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833/logs/mesos-tests-stderr.log):
```
I0314 13:07:45.303478 8836 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0314 13:07:45.305477 8836 registrar.cpp:552] Successfully updated the registry in 999936ns
I0314 13:07:45.305477 8836 registrar.cpp:424] Successfully recovered registrar
I0314 13:07:45.306475 7348 master.cpp:1787] Recovered 0 agents from the registry (239B); allowing 10mins for agents to reregister
I0314 13:07:45.314481 9040 scheduler.cpp:188] Version: 1.6.0
I0314 13:07:45.314481 9620 scheduler.cpp:311] Using default 'basic' HTTP authenticatee
I0314 13:07:45.315476 8284 scheduler.cpp:494] New master detected at master@10.3.1.8:49968
I0314 13:07:45.322475 1968 scheduler.cpp:468] Re-detecting master
I0314 13:07:45.324477 1968 scheduler.cpp:494] New master detected at master@10.3.1.8:49968
I0314 13:07:45.331480 7516 scheduler.cpp:472] Lost leading master
I0314 13:07:45.336482 9040 master.cpp:1131] Master terminating
I0314 13:07:45.359482 9040 cluster.cpp:172] Creating default 'local' authorizer
I0314 13:07:45.368505 12888 master.cpp:458] Master 0ffc4c2d-e9a7-4760-8a95-31cd4108b422 (win-bld-srv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) started on 10.3.1.8:49968
I0314 13:07:45.368505 12888 master.cpp:460] Flags at startup: --acls="" --agent_ping_timeout="15secs" --agent_reregister_timeout="10mins" --allocation_interval="1secs" --allocator="HierarchicalDRF" --authenticate_agents="true" --authenticate_frameworks="true" --authenticate_http_frameworks="true" --authenticate_http_readonly="true" --authenticate_http_readwrite="true" --authenticators="crammd5" --authorizers="local" --credentials="C:\Users\mesos\AppData\Local\Temp\LDAg8f\credentials" --filter_gpu_resources="true" --framework_sorter="drf" --help="false" --hostname_lookup="true" --http_authenticators="basic" --http_framework_authenticators="basic" --initialize_driver_logging="true" --log_auto_initialize="true" --logbufsecs="0" --logging_level="INFO" --max_agent_ping_timeouts="5" --max_completed_frameworks="50" --max_completed_tasks_per_framework="1000" --max_unreachable_tasks_per_framework="1000" --port="5050" --quiet="false" --recovery_agent_removal_limit="100%" --registry="in_memory"
--registry_fetch_timeout="1mins" --registry_gc_interval="15mins" --registry_max_agent_age="2weeks" --registry_max_agent_count="102400" --registry_store_timeout="100secs" --registry_strict="false" --require_agent_domain="false" --root_submissions="true" --user_sorter="drf" --version="false" --webui_dir="/webui" --work_dir="C:\Users\mesos\AppData\Local\Temp\LDAg8f\master" --zk_session_timeout="10secs"
I0314 13:07:45.370530 12888 master.cpp:509] Master only allowing authenticated frameworks to register
I0314 13:07:45.370530 12888 master.cpp:515] Master only allowing authenticated agents to register
I0314 13:07:45.370530 12888 master.cpp:521] Master only allowing authenticated HTTP frameworks to register
I0314 13:07:45.371481 12888 credentials.hpp:37] Loading credentials for authentication from 'C:\Users\mesos\AppData\Local\Temp\LDAg8f\credentials'
I0314 13:07:45.372505 12888 master.cpp:565] Using default 'crammd5' authenticator
I0314 13:07:45.373507 12888 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readonly'
I0314 13:07:45.373507 12888 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-readwrite'
I0314 13:07:45.374505 12888 http.cpp:1045] Creating default 'basic' HTTP authenticator for realm 'mesos-master-scheduler'
I0314 13:07:45.374505 12888 master.cpp:644] Authorization enabled
I0314 13:07:45.384479 3368 master.cpp:2114] Elected as the leading master!
I0314 13:07:45.384479 3368 master.cpp:1673] Recovering from registrar
I0314 13:07:45.385483 11480 registrar.cpp:391] Successfully fetched the registry (0B) in 1.004032ms
I0314 13:07:45.385483 11480 registrar.cpp:495] Applied 1 operations in 0ns; attempting to update the registry
I0314 13:07:45.386487 11480 registrar.cpp:552] Successfully updated the registry in 1.005056ms
ABORT: (D:\DCOS\mesos\mesos\3rdparty\libprocess\include\process/ssl/gtest.hpp:171): Could not generate certificate: Failed to set common name: X509_NAME_add_entry_by_txt
```
- Mesos Reviewbot Windows
On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 12:55 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6
> include/mesos/v1/master/master.proto 6034bd5af8ad764f625f9fe80be08b48707bbadb
> src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271
> src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4
>
>
> Diff: https://reviews.apache.org/r/65833/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 13, 2018, 7:07 p.m., Greg Mann wrote:
> > I'm also unable to view the protobuf utils diff in RB, strange. Unfortunately, it looks like there is a conflict right now so I can't apply in order to view the diff either.
I have rebased the changes on a current recent master. They overlap with and depend on changes from https://reviews.apache.org/r/65591/.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199099
-----------------------------------------------------------
On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 1:55 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6
> include/mesos/v1/master/master.proto 6034bd5af8ad764f625f9fe80be08b48707bbadb
> src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271
> src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4
>
>
> Diff: https://reviews.apache.org/r/65833/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199099
-----------------------------------------------------------
I'm also unable to view the protobuf utils diff in RB, strange. Unfortunately, it looks like there is a conflict right now so I can't apply in order to view the diff either.
- Greg Mann
On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 12:55 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
>
>
> Diff: https://reviews.apache.org/r/65833/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199466
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 12:55 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6
> include/mesos/v1/master/master.proto 6034bd5af8ad764f625f9fe80be08b48707bbadb
> src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271
> src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4
>
>
> Diff: https://reviews.apache.org/r/65833/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review198394
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65587, 65588, 65589, 65590, 65591, 65832, 65833]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 12:55 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
>
>
> Diff: https://reviews.apache.org/r/65833/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review199236
-----------------------------------------------------------
Patch looks great!
Reviews applied: [65587, 65588, 65589, 65590, 65591, 65673, 65674, 65832, 65833]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Feb. 28, 2018, 12:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 12:55 p.m.)
>
>
> Review request for mesos, Greg Mann, Jie Yu, and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto 6622e1b82861f380346f505eca326f7174dd8bd6
> include/mesos/v1/master/master.proto 6034bd5af8ad764f625f9fe80be08b48707bbadb
> src/common/protobuf_utils.cpp 9c5fb97afb58f98013b79f3cbaea7dacc3603271
> src/tests/api_tests.cpp e81d6ed25984c14e4143a048848c96e44e4f16e4
>
>
> Diff: https://reviews.apache.org/r/65833/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review198387
-----------------------------------------------------------
PASS: Mesos patch 65833 was successfully built and tested.
Reviews applied: `['65587', '65588', '65589', '65590', '65591', '65832', '65833']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65833
- Mesos Reviewbot Windows
On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 1:55 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
>
>
> Diff: https://reviews.apache.org/r/65833/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 65833: Displayed resource provider resources in
GET_AGENTS response.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65833/#review198448
-----------------------------------------------------------
Fix it, then Ship it!
I'm seeing a display issue for `protobuf_utils.cpp` in RB UI. Checked that file in a diff viewer after applying the patch to current `master`.
src/tests/api_tests.cpp
Line 229 (original), 229 (patched)
<https://reviews.apache.org/r/65833/#comment278589>
As this represents a single disk resource, let's name it `resource` or `disk`. `disk` is what's used in similar test in `master_tests.cpp`.
- Jan Schlicht
On Feb. 28, 2018, 1:55 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65833/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 1:55 p.m.)
>
>
> Review request for mesos, Jie Yu and Jan Schlicht.
>
>
> Bugs: MESOS-8388
> https://issues.apache.org/jira/browse/MESOS-8388
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Displayed resource provider resources in GET_AGENTS response.
>
>
> Diffs
> -----
>
> include/mesos/master/master.proto f40caa2a6338ff58a325444cfb72cd24f2c99472
> include/mesos/v1/master/master.proto 67c9560eaa7bd6b20b73af07f7666f0d98c4453d
> src/common/protobuf_utils.cpp d2ada356be4c26290692bc99e7ec5121039bda4e
> src/tests/api_tests.cpp 9c172f751b11b3b50f23253d212c2eb603da9c2c
>
>
> Diff: https://reviews.apache.org/r/65833/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>