You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/10/22 02:14:50 UTC
[Bug 62843] New: Tomcat Russian localization
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
Bug ID: 62843
Summary: Tomcat Russian localization
Product: Tomcat 9
Version: unspecified
Hardware: PC
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: i.krasnoffff@gmail.com
Target Milestone: -----
Created attachment 36202
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36202&action=edit
Index Page Lacalisation
Hello,
My previous patch for localization was contributed some time ago - it's bug
62558 (https://bz.apache.org/bugzilla/show_bug.cgi?id=62558).
I have completed work on the next patch. It internationalizes the homepage. I
made English and Russian translations. However, other languages can be added
there.
I look forward to your comments \ amendments \ wishes.I look forward to your
comments \ amendments \ wishes!
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #3 from Ivan Krasnov <i....@gmail.com> ---
Created attachment 36246
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36246&action=edit
Home Page Localisation V1.1
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #5 from Ivan Krasnov <i....@gmail.com> ---
(In reply to Mark Thomas from comment #4)
> You can't add anything in the java or javax package space as they are
> controlled by the specifications.
>
> Please update the patches to the latest source code, removing the changes
> that have already been applied.
>
> I think it would be better to add the l10n strings via a custom tag that
> looks up the provided key for the user's (not Tomcat's) locale in the
> resource bundle. Or similar. Unless there is something standard available
> that does this already. JSTL?
> StringManager could provide much of the required functionality but as an
> internal Tomcat class it would not normally by visible to a web application.
>
> I'll extract the Deploy/Undeploy fix and apply it.
Hello! I made changes and released a new diff. Now my class is not connected
with java or javax package, I added it to your apache tomkat package. Is that
acceptable?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #2 from Ivan Krasnov <i....@gmail.com> ---
Good day!
I created a new class and package to localize the home page. However, I was
never able to achieve the creation of a new .jar file for my package during the
bulding phase. The home page is crashing because of this. I solved this problem
by inserting my new class into an already existing package. Now everything
works fine, index page completely internationalized.
If you are not satisfied with this way of avoiding the ".jar "problem or are
not satisfied with the package in which I added my class, I will try to do it
differently.
About Manager App - yes, there was a typo there, in my diff file i am
correcting this mistake
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #7 from Christopher Schultz <ch...@christopherschultz.net> ---
I just noticed that this was a (JSP) source code patch as well as a
localization. The code itself is not great. It should use e.g. JSTL and use
on-demand localization instead of statically-loading the strings on
initialization.
The localizations are probably fine (I'd like e.g. Konstantin to validate the
Russian translation); the implementation of the internationalization just needs
to be done differently.
We don't currently have a dependency on JSTL. How does everyone feel about
adding that as a dependency?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #4 from Mark Thomas <ma...@apache.org> ---
You can't add anything in the java or javax package space as they are
controlled by the specifications.
Please update the patches to the latest source code, removing the changes that
have already been applied.
I think it would be better to add the l10n strings via a custom tag that looks
up the provided key for the user's (not Tomcat's) locale in the resource
bundle. Or similar. Unless there is something standard available that does this
already. JSTL?
StringManager could provide much of the required functionality but as an
internal Tomcat class it would not normally by visible to a web application.
I'll extract the Deploy/Undeploy fix and apply it.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #6 from Ivan Krasnov <i....@gmail.com> ---
Created attachment 36283
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36283&action=edit
Home Page Localisation V1.2
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 62843] Tomcat Russian localization
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62843
--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> ---
Ivan, do you verify what the final result is (after the patch is applied)?
E.g. in the manager app "Deploy" and "Undeploy" are translated with the same
word. It looks odd.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org