You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2023/01/12 12:22:13 UTC
[GitHub] [incubator-pekko] jchapuis opened a new pull request, #100: Renames in doc #98
jchapuis opened a new pull request, #100:
URL: https://github.com/apache/incubator-pekko/pull/100
Rename Akka to Pekko in the documentation (and remove references to Lightbend/Typesafe)
Left out direct documentation URLs for a second step (but updated the labels)
Also adapted or removed blocks of text wherever I thought relevant: I had to make some decisions sometimes, which can obviously be challenged.
The migration and security sections in particular were problematic, as they would have referenced versions of Pekko that cannot exist.
I removed the links to videos as I was doubting we would go so far as adapting the videos.
I also removed references to the activator template. I left references to the quickstart guide, but this will need to either be removed or ported over (and similarily for the tutorial guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068069965
##########
docs/src/main/paradox/general/jmm.md:
##########
@@ -1,10 +1,10 @@
---
-project.description: Akka, Actors, Futures and the Java Memory Model.
+project.description: Pekko, Actors, Futures and the Java Memory Model.
---
-# Akka and the Java Memory Model
+# Pekko and the Java Memory Model
-A major benefit of using the Lightbend Platform, including Scala and Akka, is that it simplifies the process of writing
Review Comment:
small wording adaptation here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1070921436
##########
docs/src/main/paradox/project/migration-guides.md:
##########
@@ -1,14 +1,12 @@
---
-project.description: Akka version migration guides.
+project.description: Pekko version migration guides.
---
# Migration Guides
@@toc { depth=1 }
@@@ index
-* [migration-guide-2.5.x-2.6.x](migration-guide-2.5.x-2.6.x.md)
-* [migration-guide-2.4.x-2.5.x](migration-guide-2.4.x-2.5.x.md)
-* [migration-guide-old](migration-guide-old.md)
+TODO ADD AKKA -> PEKKO MIGRATION GUIDE HERE
Review Comment:
yes good idea, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068072468
##########
docs/src/main/paradox/project/licenses.md:
##########
@@ -1,31 +1,3 @@
# Licenses
-## Akka License
-
-```
-This software is licensed under the Apache 2 license, quoted below.
-
-Copyright 2009-2018 Lightbend Inc. <https://www.lightbend.com>
-
-Licensed under the Apache License, Version 2.0 (the "License"); you may not
-use this file except in compliance with the License. You may obtain a copy of
-the License at
-
- https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations under
-the License.
-```
-
-## Akka Committer License Agreement
-
-All committers have signed this [CLA](https://www.lightbend.com/contribute/cla/akka/current).
-It can be [signed online](https://www.lightbend.com/contribute/cla/akka).
-
-## Licenses for Dependency Libraries
-
-Each dependency and its license can be seen in the project build file (the comment on the side of each dependency):
-@extref[AkkaBuild.scala](github:project/AkkaBuild.scala#L1054)
+TODO ADD LICENSE HERE
Review Comment:
That's where we'll need a license, I guess?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068064002
##########
docs/src/main/paradox/additional/operations.md:
##########
@@ -55,11 +55,4 @@ From JMX you can:
* mark any node in the cluster as down
* tell any node in the cluster to leave
-Member nodes are identified by their address, in format *`akka://actor-system-name@hostname:port`*.
-
-## Monitoring and Observability
Review Comment:
same here, Lightbend offering. Have we reached out to Kamon, or have they approached us? we could mention them here maybe, in the future 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068075179
##########
docs/src/main/paradox/project/rolling-update.md:
##########
@@ -14,104 +14,4 @@ update completely before starting next update.
@ref:[Rolling update from classic remoting to Artery](../additional/rolling-updates.md#migrating-from-classic-remoting-to-artery) is not supported since the protocol
is completely different. It will require a full cluster shutdown and new startup.
-@@@
Review Comment:
same here, changelog references concrete Akka versions, not Pekko ones
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis merged pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis merged PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1070921628
##########
docs/src/main/paradox/project/licenses.md:
##########
@@ -1,31 +1,3 @@
# Licenses
-## Akka License
-
-```
-This software is licensed under the Apache 2 license, quoted below.
-
-Copyright 2009-2018 Lightbend Inc. <https://www.lightbend.com>
-
-Licensed under the Apache License, Version 2.0 (the "License"); you may not
-use this file except in compliance with the License. You may obtain a copy of
-the License at
-
- https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations under
-the License.
-```
-
-## Akka Committer License Agreement
-
-All committers have signed this [CLA](https://www.lightbend.com/contribute/cla/akka/current).
-It can be [signed online](https://www.lightbend.com/contribute/cla/akka).
-
-## Licenses for Dependency Libraries
-
-Each dependency and its license can be seen in the project build file (the comment on the side of each dependency):
-@extref[AkkaBuild.scala](github:project/AkkaBuild.scala#L1054)
+TODO ADD LICENSE HERE
Review Comment:
👍 done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068667761
##########
docs/src/main/paradox/project/licenses.md:
##########
@@ -1,31 +1,3 @@
# Licenses
-## Akka License
-
-```
-This software is licensed under the Apache 2 license, quoted below.
-
-Copyright 2009-2018 Lightbend Inc. <https://www.lightbend.com>
-
-Licensed under the Apache License, Version 2.0 (the "License"); you may not
-use this file except in compliance with the License. You may obtain a copy of
-the License at
-
- https://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing, software
-distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
-WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
-License for the specific language governing permissions and limitations under
-the License.
-```
-
-## Akka Committer License Agreement
-
-All committers have signed this [CLA](https://www.lightbend.com/contribute/cla/akka/current).
-It can be [signed online](https://www.lightbend.com/contribute/cla/akka).
-
-## Licenses for Dependency Libraries
-
-Each dependency and its license can be seen in the project build file (the comment on the side of each dependency):
-@extref[AkkaBuild.scala](github:project/AkkaBuild.scala#L1054)
+TODO ADD LICENSE HERE
Review Comment:
just link to https://www.apache.org/licenses/LICENSE-2.0 and https://www.apache.org/licenses/contributor-agreements.html#clas for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068075959
##########
docs/src/main/paradox/remoting-artery.md:
##########
@@ -315,11 +311,7 @@ According to [RFC 7525](https://www.rfc-editor.org/rfc/rfc7525.html) the recomme
You should always check the latest information about security and algorithm recommendations though before you configure your system.
-Creating and working with keystores and certificates is well documented in the
-[Generating X.509 Certificates](https://lightbend.github.io/ssl-config/CertificateGeneration.html#using-keytool)
Review Comment:
removed the link to this guide, which is lightbend branded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068060384
##########
docs/src/main/paradox/.htaccess:
##########
@@ -2,19 +2,8 @@ RedirectMatch 301 ^(.*)/scala/(.*) $1/$2?language=scala
RedirectMatch 301 ^(.*)/java/(.*) $1/$2?language=java
RedirectMatch 301 ^(.*)/stream/stages-overview\.html.* $1/stream/operators/index.html
-RedirectMatch 301 ^(.*)/project/migration-guide-1\.3\.x-2\.0\.x\.html.* $1/project/migration-guide-old.html
Review Comment:
these redirects no longer seemed relevant, as I also decided to remove the migration guides for specific Akka versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068072840
##########
docs/src/main/paradox/project/links.md:
##########
@@ -1,42 +1,21 @@
# Project
-## Commercial Support
Review Comment:
naturally removed those entries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068061160
##########
docs/src/main/paradox/actors.md:
##########
@@ -293,13 +293,6 @@ described here: @ref:[What Restarting Means](general/supervision.md#supervision-
When using a dependency injection framework, actor beans *MUST NOT* have
singleton scope.
-@@@
-
-Techniques for dependency injection and integration with dependency injection frameworks
Review Comment:
specialized guide here that I thought would no longer be worth mentioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068079609
##########
project/Paradox.scala:
##########
@@ -29,15 +29,15 @@ object Paradox {
"canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.akka.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
Review Comment:
the base_urls can be changed here, once we have ported the corresponding pieces
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068068722
##########
docs/src/main/paradox/common/other-modules.md:
##########
@@ -1,80 +1,62 @@
-# Other Akka modules
+# Other Pekko modules
-This page describes modules that compliment libraries from the Akka core. See [this overview](https://doc.akka.io/docs/akka/current/typed/guide/modules.html) instead for a guide on the core modules.
+This page describes modules that compliment libraries from the Pekko core. See [this overview](https://doc.akka.io/docs/akka/current/typed/guide/modules.html) instead for a guide on the core modules.
-## [Akka HTTP](https://doc.akka.io/docs/akka-http/current/)
+## [Pekko HTTP](https://doc.akka.io/docs/akka-http/current/)
-A full server- and client-side HTTP stack on top of akka-actor and akka-stream.
+A full server- and client-side HTTP stack on top of pekko-actor and pekko-stream.
-## [Akka gRPC](https://doc.akka.io/docs/akka-grpc/current/)
+## [Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/)
-Akka gRPC provides support for building streaming gRPC servers and clients on top of Akka Streams.
+Pekko gRPC provides support for building streaming gRPC servers and clients on top of Pekko Streams.
-## [Alpakka](https://doc.akka.io/docs/alpakka/current/)
+## [Pekko Connectors](https://doc.akka.io/docs/alpakka/current/)
-Alpakka is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Akka.
+Pekko Connectors is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Pekko.
-## [Alpakka Kafka Connector](https://doc.akka.io/docs/alpakka-kafka/current/)
+## [Pekko Kafka Connector](https://doc.akka.io/docs/alpakka-kafka/current/)
-The Alpakka Kafka Connector connects Apache Kafka with Akka Streams.
+The Pekko Kafka Connector connects Apache Kafka with Pekko Streams.
-## [Akka Projections](https://doc.akka.io/docs/akka-projection/current/)
+## [Pekko Projections](https://doc.akka.io/docs/akka-projection/current/)
-Akka Projections let you process a stream of events or records from a source to a projected model or external system.
+Pekko Projections let you process a stream of events or records from a source to a projected model or external system.
-## [Cassandra Plugin for Akka Persistence](https://doc.akka.io/docs/akka-persistence-cassandra/current/)
+## [Cassandra Plugin for Pekko Persistence](https://doc.akka.io/docs/akka-persistence-cassandra/current/)
-An Akka Persistence journal and snapshot store backed by Apache Cassandra.
+An Pekko Persistence journal and snapshot store backed by Apache Cassandra.
-## [JDBC Plugin for Akka Persistence](https://doc.akka.io/docs/akka-persistence-jdbc/current/)
+## [JDBC Plugin for Pekko Persistence](https://doc.akka.io/docs/akka-persistence-jdbc/current/)
-An Akka Persistence journal and snapshot store for use with JDBC-compatible databases. This implementation relies on [Slick](https://scala-slick.org/).
+An Pekko Persistence journal and snapshot store for use with JDBC-compatible databases. This implementation relies on [Slick](https://scala-slick.org/).
-## [R2DBC Plugin for Akka Persistence](https://doc.akka.io/docs/akka-persistence-r2dbc/current/)
+## [R2DBC Plugin for Pekko Persistence](https://doc.akka.io/docs/akka-persistence-r2dbc/current/)
-An Akka Persistence journal and snapshot store for use with R2DBC-compatible databases. This implementation relies on [R2DBC](https://r2dbc.io/).
+A Pekko Persistence journal and snapshot store for use with R2DBC-compatible databases. This implementation relies on [R2DBC](https://r2dbc.io/).
-## [Google Cloud Spanner Plugin for Akka Persistence](https://doc.akka.io/docs/akka-persistence-spanner/current/)
+## [Google Cloud Spanner Plugin for Pekko Persistence](https://doc.akka.io/docs/akka-persistence-spanner/current/)
-Use [Google Cloud Spanner](https://cloud.google.com/spanner/) as Akka Persistence journal and snapshot store. This integration relies on [Akka gRPC](https://doc.akka.io/docs/akka-grpc/current/).
+Use [Google Cloud Spanner](https://cloud.google.com/spanner/) as Pekko Persistence journal and snapshot store. This integration relies on [Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/).
-## Akka Management
+## Pekko Management
-* [Akka Management](https://doc.akka.io/docs/akka-management/current/) provides a central HTTP endpoint for Akka management extensions.
-* [Akka Cluster Bootstrap](https://doc.akka.io/docs/akka-management/current/bootstrap/) helps bootstrapping an Akka cluster using Akka Discovery.
-* [Akka Management Cluster HTTP](https://doc.akka.io/docs/akka-management/current/cluster-http-management.html) provides HTTP endpoints for introspecting and managing Akka clusters.
-* [Akka Discovery for Kubernetes, Consul, Marathon, and AWS](https://doc.akka.io/docs/akka-management/current/discovery/)
+* [Pekko Management](https://doc.akka.io/docs/akka-management/current/) provides a central HTTP endpoint for Pekko management extensions.
+* [Pekko Cluster Bootstrap](https://doc.akka.io/docs/akka-management/current/bootstrap/) helps bootstrapping an Pekko cluster using Pekko Discovery.
+* [Pekko Management Cluster HTTP](https://doc.akka.io/docs/akka-management/current/cluster-http-management.html) provides HTTP endpoints for introspecting and managing Pekko clusters.
+* [Pekko Discovery for Kubernetes, Consul, Marathon, and AWS](https://doc.akka.io/docs/akka-management/current/discovery/)
* [Kubernetes Lease](https://doc.akka.io/docs/akka-management/current/kubernetes-lease.html)
-## Akka Resilience Enhancements
+## Pekko Resilience Enhancements
-* [Akka Thread Starvation Detector](https://doc.akka.io/docs/akka-enhancements/current/starvation-detector.html)
-* [Akka Configuration Checker](https://doc.akka.io/docs/akka-enhancements/current/config-checker.html)
-* [Akka Diagnostics Recorder](https://doc.akka.io/docs/akka-enhancements/current/diagnostics-recorder.html)
+* [Pekko Thread Starvation Detector](https://doc.akka.io/docs/akka-enhancements/current/starvation-detector.html)
+* [Pekko Configuration Checker](https://doc.akka.io/docs/akka-enhancements/current/config-checker.html)
+* [Pekko Diagnostics Recorder](https://doc.akka.io/docs/akka-enhancements/current/diagnostics-recorder.html)
-## Akka Persistence Enhancements
+## Pekko Persistence Enhancements
-* [Akka GDPR for Persistence](https://doc.akka.io/docs/akka-enhancements/current/gdpr/index.html)
+* [Pekko GDPR for Persistence](https://doc.akka.io/docs/akka-enhancements/current/gdpr/index.html)
-## Community Projects
Review Comment:
Removed this section about community and sponsored projects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068066447
##########
docs/src/main/paradox/cluster-singleton.md:
##########
@@ -93,9 +93,6 @@ Scala
Java
: @@snip [ClusterSingletonManagerTest.java](/cluster-tools/src/test/java/org/apache/pekko/cluster/singleton/ClusterSingletonManagerTest.java) { #create-singleton-proxy }
-A more comprehensive sample is available in the tutorial named
Review Comment:
activator template link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068066008
##########
docs/src/main/paradox/camel.md:
##########
@@ -1,7 +0,0 @@
-# Camel
Review Comment:
this seemed outdated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068065392
##########
docs/src/main/paradox/additional/rolling-updates.md:
##########
@@ -101,61 +101,14 @@ if there is an unreachability problem Split Brain Resolver would make a decision
## Configuration Compatibility Checks
During rolling updates the configuration from existing nodes should pass the Cluster configuration compatibility checks.
-For example, it is possible to migrate Cluster Sharding from Classic to Typed Actors in a rolling update using a two step approach
-as of Akka version `2.5.23`:
+For example, it is possible to migrate Cluster Sharding from Classic to Typed Actors in a rolling update using a two step approach:
* Deploy with the new nodes set to `pekko.cluster.configuration-compatibility-check.enforce-on-join = off`
and ensure all nodes are in this state
* Deploy again and with the new nodes set to `pekko.cluster.configuration-compatibility-check.enforce-on-join = on`.
Full documentation about enforcing these checks on joining nodes and optionally adding custom checks can be found in
-@ref:[Akka Cluster configuration compatibility checks](../typed/cluster.md#configuration-compatibility-check).
-
-## Rolling Updates and Migrating Akka
-
-### From Java serialization to Jackson
-
-If you are migrating from Akka 2.5 to 2.6, and use Java serialization you can replace it with, for example, the new
Review Comment:
Every time a concrete Akka version was mentioned, I had to make a decision, because there is no Pekko equivalent. So here, I am removing this detailed migration guide
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068066991
##########
docs/src/main/paradox/cluster-usage.md:
##########
@@ -388,12 +388,12 @@ or similar instead.
@@@
-The cluster can be managed with the script `akka-cluster` provided in the Akka GitHub repository @extref[here](github:akka-cluster/jmx-client). Place the script and the `jmxsh-R5.jar` library in the same directory.
+The cluster can be managed with the script `pekko-cluster` provided in the Pekko GitHub repository @extref[here](github:cluster/jmx-client). Place the script and the `jmxsh-R5.jar` library in the same directory.
Run it without parameters to see instructions about how to use the script:
```
-Usage: ./akka-cluster <node-hostname> <jmx-port> <command> ...
Review Comment:
(i renamed the actual script file as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068064002
##########
docs/src/main/paradox/additional/operations.md:
##########
@@ -55,11 +55,4 @@ From JMX you can:
* mark any node in the cluster as down
* tell any node in the cluster to leave
-Member nodes are identified by their address, in format *`akka://actor-system-name@hostname:port`*.
-
-## Monitoring and Observability
Review Comment:
same here, Lightbend offering. Have we reached out to Kamon, or have they approached us? we could mention them there maybe 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068062175
##########
docs/src/main/paradox/additional/deploying.md:
##########
@@ -1,18 +1,16 @@
---
-project.description: How to deploy Akka Cluster to Kubernetes and Docker.
+project.description: How to deploy Pekko Cluster to Kubernetes and Docker.
---
# Deploying
## Deploying to Kubernetes
-[Akka Cloud Platform](https://developer.lightbend.com/docs/akka-platform-guide/deployment/index.html) is the easiest way to deploy an Akka Cluster application to Amazon Elastic Kubernetes Service (EKS) or Google Kubernetes Engine (GKE).
Review Comment:
removed links to Lightbend offerings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068069162
##########
docs/src/main/paradox/discovery/index.md:
##########
@@ -1,35 +1,24 @@
---
-project.description: Service discovery with Akka using DNS, Kubernetes, AWS, Consul or Marathon.
+project.description: Service discovery with Pekko using DNS, Kubernetes, AWS, Consul or Marathon.
---
# Discovery
-The Akka Discovery API enables **service discovery** to be provided by different technologies.
+The Pekko Discovery API enables **service discovery** to be provided by different technologies.
It allows to delegate endpoint lookup so that services can be configured depending on the environment by other means than configuration files.
-Implementations provided by the Akka Discovery module are
+Implementations provided by the Pekko Discovery module are
* @ref:[Configuration](#discovery-method-configuration) (HOCON)
* @ref:[DNS](#discovery-method-dns) (SRV records)
* @ref:[Aggregate](#discovery-method-aggregate-multiple-discovery-methods) multiple discovery methods
-In addition the @extref:[Akka Management](akka-management:) toolbox contains Akka Discovery implementations for
+In addition, the @extref:[Pekko Management](pekko-management:) toolbox contains Pekko Discovery implementations for
-* @extref:[Kubernetes API](akka-management:discovery/kubernetes.html)
-* @extref:[AWS API: EC2 Tag-Based Discovery](akka-management:discovery/aws.html#discovery-method-aws-api-ec2-tag-based-discovery)
-* @extref:[AWS API: ECS Discovery](akka-management:discovery/aws.html#discovery-method-aws-api-ecs-discovery)
-* @extref:[Consul](akka-management:discovery/consul.html)
-* @extref:[Marathon API](akka-management:discovery/marathon.html)
-
-
-@@@ note
Review Comment:
I thought Akka evolution history wasn't worth keeping here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068073393
##########
docs/src/main/paradox/project/migration-guide-2.4.x-2.5.x.md:
##########
@@ -1,4 +0,0 @@
-# Migration Guide 2.4.x to 2.5.x
Review Comment:
as mentioned, I removed the detailed migration guides that apply for older Akka versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068063236
##########
docs/src/main/paradox/additional/faq.md:
##########
@@ -70,11 +56,4 @@ To turn on debug logging in your actor system add the following to your configur
pekko.loglevel = DEBUG
```
-Read more about it in the docs for @ref:[Logging](../typed/logging.md).
-
-# Other questions?
-
-Do you have a question not covered here? Find out how to
Review Comment:
removed this block as I'm not sure we want to offer smth like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068062669
##########
docs/src/main/paradox/additional/faq.md:
##########
@@ -1,26 +1,12 @@
# Frequently Asked Questions
-## Akka Project
+## Pekko Project
-### Where does the name Akka come from?
+### Where does the name Pekko come from?
-It is the name of a beautiful Swedish [mountain](https://en.wikipedia.org/wiki/%C3%81hkk%C3%A1)
Review Comment:
I adapted this text here to include both gods 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068074324
##########
docs/src/main/paradox/project/migration-guides.md:
##########
@@ -1,14 +1,12 @@
---
-project.description: Akka version migration guides.
+project.description: Pekko version migration guides.
---
# Migration Guides
@@toc { depth=1 }
@@@ index
-* [migration-guide-2.5.x-2.6.x](migration-guide-2.5.x-2.6.x.md)
-* [migration-guide-2.4.x-2.5.x](migration-guide-2.4.x-2.5.x.md)
-* [migration-guide-old](migration-guide-old.md)
+TODO ADD AKKA -> PEKKO MIGRATION GUIDE HERE
Review Comment:
it would probably be interesting to elaborate a migration guide from Akka to Pekko at some point
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068077007
##########
docs/src/main/paradox/security/2017-02-10-java-serialization.md:
##########
@@ -1,55 +0,0 @@
-# Java Serialization, Fixed in Akka 2.4.17
Review Comment:
removed security articles about particular Akka versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
pjfanning commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068117611
##########
docs/src/main/paradox/project/migration-guides.md:
##########
@@ -1,14 +1,12 @@
---
-project.description: Akka version migration guides.
+project.description: Pekko version migration guides.
---
# Migration Guides
@@toc { depth=1 }
@@@ index
-* [migration-guide-2.5.x-2.6.x](migration-guide-2.5.x-2.6.x.md)
-* [migration-guide-2.4.x-2.5.x](migration-guide-2.4.x-2.5.x.md)
-* [migration-guide-old](migration-guide-old.md)
+TODO ADD AKKA -> PEKKO MIGRATION GUIDE HERE
Review Comment:
Could you include a link to the real Akka migration guides and encourage users who are not using versions of Akka older than v2.6.x to start by reading how to migrate to v2.6.x? They can assume that they'll need to allow for those migration steps as well as the Akka to Pekko migration steps (when we provide those).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068071341
##########
docs/src/main/paradox/project/downstream-upgrade-strategy.md:
##########
@@ -3,41 +3,36 @@ project.description: Upgrade strategy for downstream libraries
---
# Downstream upgrade strategy
-When a new Akka version is released, downstream projects (such as
-[Akka Management](https://doc.akka.io/docs/akka-management/current/),
-[Akka HTTP](https://doc.akka.io/docs/akka-http/current/) and
-[Akka gRPC](https://doc.akka.io/docs/akka-grpc/current/))
+When a new Pekko version is released, downstream projects (such as
+[Pekko Management](https://doc.akka.io/docs/akka-management/current/),
+[Pekko HTTP](https://doc.akka.io/docs/akka-http/current/) and
+[Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/))
do not need to update immediately: because of our
@ref[binary compatibility](../common/binary-compatibility-rules.md) approach,
-applications can take advantage of the latest version of Akka without having to
+applications can take advantage of the latest version of Pekko without having to
wait for intermediate libraries to update.
## Patch versions
-When releasing a new patch version of Akka (e.g. 2.5.22), we typically don't
-immediately bump the Akka version in satellite projects.
+When releasing a new patch version of Pekko (e.g. 2.5.22), we typically don't
+immediately bump the Pekko version in satellite projects.
The reason for this is this will make it more low-friction for users to update
-those satellite projects: say their project is on Akka 2.5.22 and
-Akka Management 1.0.0, and we release Akka Management 1.0.1 (still built with
-Akka 2.5.22) and Akka 2.5.23. They can safely update to Akka Management 1.0.1
-without also updating to Akka 2.5.23, or update to Akka 2.5.23 without updating
-to Akka Management 1.0.1.
+those satellite projects: say their project is on Pekko 2.5.22 and
Review Comment:
examples are still for versions that don't exist here (but they are just examples). Maybe we'll want to adapt this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] jchapuis commented on a diff in pull request #100: Renames in doc #98
Posted by GitBox <gi...@apache.org>.
jchapuis commented on code in PR #100:
URL: https://github.com/apache/incubator-pekko/pull/100#discussion_r1068071341
##########
docs/src/main/paradox/project/downstream-upgrade-strategy.md:
##########
@@ -3,41 +3,36 @@ project.description: Upgrade strategy for downstream libraries
---
# Downstream upgrade strategy
-When a new Akka version is released, downstream projects (such as
-[Akka Management](https://doc.akka.io/docs/akka-management/current/),
-[Akka HTTP](https://doc.akka.io/docs/akka-http/current/) and
-[Akka gRPC](https://doc.akka.io/docs/akka-grpc/current/))
+When a new Pekko version is released, downstream projects (such as
+[Pekko Management](https://doc.akka.io/docs/akka-management/current/),
+[Pekko HTTP](https://doc.akka.io/docs/akka-http/current/) and
+[Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/))
do not need to update immediately: because of our
@ref[binary compatibility](../common/binary-compatibility-rules.md) approach,
-applications can take advantage of the latest version of Akka without having to
+applications can take advantage of the latest version of Pekko without having to
wait for intermediate libraries to update.
## Patch versions
-When releasing a new patch version of Akka (e.g. 2.5.22), we typically don't
-immediately bump the Akka version in satellite projects.
+When releasing a new patch version of Pekko (e.g. 2.5.22), we typically don't
+immediately bump the Pekko version in satellite projects.
The reason for this is this will make it more low-friction for users to update
-those satellite projects: say their project is on Akka 2.5.22 and
-Akka Management 1.0.0, and we release Akka Management 1.0.1 (still built with
-Akka 2.5.22) and Akka 2.5.23. They can safely update to Akka Management 1.0.1
-without also updating to Akka 2.5.23, or update to Akka 2.5.23 without updating
-to Akka Management 1.0.1.
+those satellite projects: say their project is on Pekko 2.5.22 and
Review Comment:
examples are still for versions that cannot exist here. Maybe we'll want to adapt this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org