You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 00:50:45 UTC
[I] [BUG] RedisRateLimiter silently swallows Redis errors and fail-opens (dead doOnError) [shenyu]
Aias00 opened a new issue, #6645:
URL: https://github.com/apache/shenyu/issues/6645
- severity: High
- files: `shenyu-plugin/shenyu-plugin-fault-tolerance/shenyu-plugin-ratelimiter/src/main/java/org/apache/shenyu/plugin/ratelimiter/executor/RedisRateLimiter.java:63-75`
- description: `resultFlux.onErrorResume(throwable -> Flux.just(Arrays.asList(1L, -1L)))` converts any Redis error into a normal emission of `{allowed=1, tokensLeft=-1}`. The downstream `.reduce().map()` completes successfully, so the trailing `.doOnError(...)` (which logs and calls the callback) is unreachable — `onErrorResume` already absorbed the error. Net effect: on Redis outage every request is allowed (fail-open) AND nothing is logged.
- impact: Complete, invisible bypass of rate limiting during Redis outages; operators get no log signal.
- suggested_fix: Move logging into the `onErrorResume` lambda; make fail-open vs fail-closed an explicit, logged policy.
- confidence: High
- related_existing: none — #5376/#5340/#5021 are different.
---
_Identified during the 2026-08-02 deep re-scan; full list in [`docs/scan2-2026-08-02/00-consolidated-critical-high.md`](docs/scan2-2026-08-02/00-consolidated-critical-high.md)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RedisRateLimiter silently swallows Redis errors and fail-opens (dead doOnError) [shenyu]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #6645:
URL: https://github.com/apache/shenyu/issues/6645#issuecomment-5161210246
👋 Hello @yuluo-yx
A new issue has been opened by @Aias00:
- **Title**: [BUG] RedisRateLimiter silently swallows Redis errors and fail-opens (dead doOnError)
- **Link**: https://github.com/apache/shenyu/issues/6645
Please review when you have time. Thank you! 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [BUG] RedisRateLimiter silently swallows Redis errors and fail-opens (dead doOnError) [shenyu]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed issue #6645: [BUG] RedisRateLimiter silently swallows Redis errors and fail-opens (dead doOnError)
URL: https://github.com/apache/shenyu/issues/6645
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org