You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "lucasbru (via GitHub)" <gi...@apache.org> on 2025/12/11 14:54:06 UTC
[PR] KAFKA-19987: Add metrics from KIP-1216 to ops.html [kafka]
lucasbru opened a new pull request, #21130:
URL: https://github.com/apache/kafka/pull/21130
This commit adds the new thread-level rebalance listener callback metrics from KIP-1216 to the Streams Monitoring section in ops.html:
- tasks-revoked-latency-avg and tasks-revoked-latency-max
- tasks-assigned-latency-avg and tasks-assigned-latency-max
- tasks-lost-latency-avg and tasks-lost-latency-max
All metrics are at the INFO recording level and measure time in milliseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19987: Add metrics from KIP-1216 to ops.html [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru merged PR #21130:
URL: https://github.com/apache/kafka/pull/21130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19987: Add metrics from KIP-1216 to ops.html [kafka]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #21130:
URL: https://github.com/apache/kafka/pull/21130#discussion_r2610918968
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-avg</td>
+ <td>The average time in ms taken for tasks-lost rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-max</td>
+ <td>The maximum time in ms taken for tasks-lost rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-lost rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-revoked rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-assigned rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-assigned rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-avg</td>
+ <td>The average time in ms taken for tasks-assigned rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-assigned-latency-max</td>
+ <td>The maximum time in ms taken for tasks-assigned rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-lost-latency-avg</td>
+ <td>The average time in ms taken for tasks-lost rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-avg, poll-latency-avg, process-latency-avg). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The average execution time in ms, taken for tasks-lost rebalance listener callback.</td>
```
##########
docs/ops.html:
##########
@@ -3231,6 +3231,36 @@ <h5 class="anchor-heading"><a id="kafka_streams_thread_monitoring" class="anchor
<td>The system timestamp in ms that the thread was started.</td>
<td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>tasks-revoked-latency-avg</td>
+ <td>The average time in ms taken for tasks-revoked rebalance listener callback.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>tasks-revoked-latency-max</td>
+ <td>The maximum time in ms taken for tasks-revoked rebalance listener callback.</td>
Review Comment:
The description should use "execution time" instead of "time" to be consistent with other thread-level latency metrics in this section (e.g., commit-latency-max, poll-latency-max, process-latency-max). Additionally, add a comma after "ms" to match the formatting pattern used by other thread metrics.
```suggestion
<td>The maximum execution time in ms, taken for tasks-revoked rebalance listener callback.</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-19987: Add metrics from KIP-1216 to ops.html [kafka]
Posted by "lucasbru (via GitHub)" <gi...@apache.org>.
lucasbru commented on PR #21130:
URL: https://github.com/apache/kafka/pull/21130#issuecomment-3654906020
picked to 4.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org