You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Martin Koci (JIRA)" <de...@myfaces.apache.org> on 2006/03/13 11:39:13 UTC

[jira] Created: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Dont render clear_<formName> if not in MyFacesForm
--------------------------------------------------

         Key: MYFACES-1171
         URL: http://issues.apache.org/jira/browse/MYFACES-1171
     Project: MyFaces Core
        Type: Bug
    Versions: 1.1.3-SNAPSHOT    
    Reporter: Martin Koci
    Priority: Minor


 HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
     [ http://issues.apache.org/jira/browse/MYFACES-1171?page=all ]
     
Mario Ivankovits resolved MYFACES-1171:
---------------------------------------

    Fix Version: 1.1.3
     Resolution: Fixed

from my point of view we fixed this issue by disabling the dummyForm feature by default, so as long as you do not use the t:command* stuff or a link derived from ExtendedHtmlLinkRenderer you should be fine

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Matthias Weßendorf (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12416049 ] 

Matthias Weßendorf commented on MYFACES-1171:
---------------------------------------------

Yea, Tomahawk should be run with the RI.

So we should add a note to all example (using t:commandLink) that this component (t:commandLink) is/will be deprecated

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Mike Youngstrom (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12379159 ] 

Mike Youngstrom commented on MYFACES-1171:
------------------------------------------

This issues is related to TOMAHAWK-416.  It would be nice to get some dialog started on how to fix these clear function problems and make it all cross implementation compatible.

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12416045 ] 

Mario Ivankovits commented on MYFACES-1171:
-------------------------------------------

But the t:commandLink cant work with anything else with myfaces-impl - and I dont see the badness of it, do all components of tomahawk have to work with RI?
I guess not, there are low-level things we dont manage to provide for RI due to the fact that there is simply no spec to rely to - e.g. how to render/name the form fields.

If I remember correctly, the t:commandLink provides only the dummyForm stuff - and this is deprecated for now - so ist the tag deprecated too. Once we have a way to change the view after creation (jsf 1.2) we can inject a form if its missing and then we can remove the t:command* stuff at all. (Given that we want to provide this functionallity again which is a -0 from me)

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12416048 ] 

Bruno Aranda commented on MYFACES-1171:
---------------------------------------

But, then, functionality such as the forceId for links will be lost?

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Mario Ivankovits (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12416057 ] 

Mario Ivankovits commented on MYFACES-1171:
-------------------------------------------

well, we can change our form handling to be RI compatible by using their namings and logic how to do it (I dont know anything about it as I do not use RI), but even then, tomahawk might work with myfaces and RI only, no one gurantees that it might work with other implementations (if there is one)

I wouldnt repeate myself, but whats missing is a spec about the internals of the default renderer classes and a way how to decorate a renderer.
So that we can change things without having to reimplement the whole stuff and being tied to a implementation then.

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Vofeka (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12379056 ] 

Vofeka commented on MYFACES-1171:
---------------------------------

Just for your information, I'm getting the same javascript errors when using the SUN RI with myFaces Tomahawk components. (clear_<formName> not defined).

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (MYFACES-1171) Dont render clear_ if not in MyFacesForm

Posted by "Bruno Aranda (JIRA)" <de...@myfaces.apache.org>.
    [ http://issues.apache.org/jira/browse/MYFACES-1171?page=comments#action_12416040 ] 

Bruno Aranda commented on MYFACES-1171:
---------------------------------------

This behaviour is also observed when using the JSF-RI + tomahawk for the SVN code. The call to the clear function is rendered, but not the clear function itself, thus provoking a javascript error and the command (t:commandLink) not being executed in implementations other than myfaces.

> Dont render clear_<formName> if not in MyFacesForm
> --------------------------------------------------
>
>          Key: MYFACES-1171
>          URL: http://issues.apache.org/jira/browse/MYFACES-1171
>      Project: MyFaces Core
>         Type: Bug

>     Versions: 1.1.3
>     Reporter: Martin Koci
>     Priority: Minor
>      Fix For: 1.1.3

>
>  HtmlCommandButtonRenderer alway renders onclick="clear_<formName>". But this will work only if myfaces form renderer was used. 
> With custom form renderer (and with ADF faces renderer kit too) function 'clear_<formName>" does not exist in output html.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira