You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pinot.apache.org by GitBox <gi...@apache.org> on 2018/12/01 01:28:55 UTC

[GitHub] codecov-io commented on issue #3573: Improve the logging for segment merge command

codecov-io commented on issue #3573: Improve the logging for segment merge command
URL: https://github.com/apache/incubator-pinot/pull/3573#issuecomment-443387345
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=h1) Report
   > Merging [#3573](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f1512e6774bffa17196242af7d7bab625cfc2142?src=pr&el=desc) will **decrease** coverage by `11.97%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/3573/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #3573       +/-   ##
   ============================================
   - Coverage     70.88%   58.9%   -11.98%     
     Complexity        4       4               
   ============================================
     Files           997    1147      +150     
     Lines         45779   58211    +12432     
     Branches       6137    8056     +1919     
   ============================================
   + Hits          32449   34289     +1840     
   - Misses        11208   21545    +10337     
   - Partials       2122    2377      +255
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...t/tools/segment/converter/SegmentMergeCommand.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtdG9vbHMvc3JjL21haW4vamF2YS9jb20vbGlua2VkaW4vcGlub3QvdG9vbHMvc2VnbWVudC9jb252ZXJ0ZXIvU2VnbWVudE1lcmdlQ29tbWFuZC5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPZmZIZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `72.72% <0%> (-10.91%)` | `0% <0%> (ø)` | |
   | [...kedin/pinot/core/util/SortedRangeIntersection.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3V0aWwvU29ydGVkUmFuZ2VJbnRlcnNlY3Rpb24uamF2YQ==) | `83.82% <0%> (-7.36%)` | `0% <0%> (ø)` | |
   | [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Eb3VibGVPbkhlYXBNdXRhYmxlRGljdGlvbmFyeS5qYXZh) | `68.88% <0%> (-6.67%)` | `0% <0%> (ø)` | |
   | [...inkedin/pinot/common/config/RealtimeTagConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9jb25maWcvUmVhbHRpbWVUYWdDb25maWcuamF2YQ==) | `93.33% <0%> (-6.67%)` | `0% <0%> (ø)` | |
   | [...elix/core/relocation/RealtimeSegmentRelocator.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL2hlbGl4L2NvcmUvcmVsb2NhdGlvbi9SZWFsdGltZVNlZ21lbnRSZWxvY2F0b3IuamF2YQ==) | `73.95% <0%> (-6.25%)` | `0% <0%> (ø)` | |
   | [.../impl/dictionary/LongOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb3JlL3JlYWx0aW1lL2ltcGwvZGljdGlvbmFyeS9Mb25nT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `89.09% <0%> (-3.64%)` | `0% <0%> (ø)` | |
   | [...edin/pinot/common/metadata/ZKMetadataProvider.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2NvbW1vbi9tZXRhZGF0YS9aS01ldGFkYXRhUHJvdmlkZXIuamF2YQ==) | `66.87% <0%> (-3.13%)` | `0% <0%> (ø)` | |
   | [...der/HighLevelConsumerBasedRoutingTableBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvY29tL2xpbmtlZGluL3Bpbm90L2Jyb2tlci9yb3V0aW5nL2J1aWxkZXIvSGlnaExldmVsQ29uc3VtZXJCYXNlZFJvdXRpbmdUYWJsZUJ1aWxkZXIuamF2YQ==) | `90.9% <0%> (-3.04%)` | `0% <0%> (ø)` | |
   | [...pinot/controller/validation/ValidationManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL2NvbS9saW5rZWRpbi9waW5vdC9jb250cm9sbGVyL3ZhbGlkYXRpb24vVmFsaWRhdGlvbk1hbmFnZXIuamF2YQ==) | `66.42% <0%> (-2.86%)` | `0% <0%> (ø)` | |
   | ... and [167 more](https://codecov.io/gh/apache/incubator-pinot/pull/3573/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=footer). Last update [f1512e6...9c01ef5](https://codecov.io/gh/apache/incubator-pinot/pull/3573?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pinot.apache.org
For additional commands, e-mail: dev-help@pinot.apache.org