You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2021/09/14 09:53:04 UTC
[GitHub] [knox] smolnar82 opened a new pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
smolnar82 opened a new pull request #494:
URL: https://github.com/apache/knox/pull/494
## What changes were proposed in this pull request?
There were some public API endpoints in `TokenResource` with wrong HTTP methods. I changed hem and now the resource looks like this:
- GET - `/knoxtoken/api/v1/token`
- GET - `/knoxtoken/api/v1/token/getUserTokens`
- GET - `/knoxtoken/api/v1/token/getTssStatus`
- POST - `/knoxtoken/api/v1/token`
- PUT - `/knoxtoken/api/v1/token/renew`
- PUT - `/knoxtoken/api/v1/token/enable`
- PUT - `/knoxtoken/api/v1/token/disable`
- DELETE - `/knoxtoken/api/v1/token/revoke`
## How was this patch tested?
Ran manual test steps (including token management UI operations and `curl` requests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
zeroflag commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919150330
I see, then I'm ok with it. Although the revoke + delete (and put + enable) feels a bit weird to me. There is a verb in both the HTTP method and in the path. But if it's mainly used by the UI then I think it's ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919047102
> Does this change effect existing users or is this not yet used by anyone?
We only use the `revoke` and `enable\disable` API on the token management page. Whoever uses these APIs will have to modify their clients to match the new HTTP method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 merged pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
smolnar82 merged pull request #494:
URL: https://github.com/apache/knox/pull/494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] zeroflag commented on pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
zeroflag commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919024871
Does this change effect existing users or is this not yet used by anyone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 commented on pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
smolnar82 commented on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919014456
Cc. @zeroflag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [knox] smolnar82 edited a comment on pull request #494: KNOX-2661 - Consolidated HTTP methods in TokenResource
Posted by GitBox <gi...@apache.org>.
smolnar82 edited a comment on pull request #494:
URL: https://github.com/apache/knox/pull/494#issuecomment-919047102
> Does this change effect existing users or is this not yet used by anyone?
We only use the `revoke` and `enable\disable` API on the token management page where I implemented the changes too.
Whoever uses these APIs will have to modify their clients to match the new HTTP method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org