[GitHub] [pinot] ankitsultana commented on a diff in pull request #10409: [multistage] Fix Predicate Pushdown by Using Rule Collection

["ankitsultana (via GitHub)" <gi...@apache.org>]

ankitsultana commented on code in PR #10409:
URL: https://github.com/apache/pinot/pull/10409#discussion_r1135883480


##########
pinot-query-planner/src/test/resources/queries/AggregatePlans.json:
##########
@@ -6,14 +6,13 @@
         "sql": "EXPLAIN PLAN FOR SELECT AVG(a.col4) as avg FROM a WHERE a.col3 >= 0 AND a.col2 = 'pink floyd'",
         "output": [
           "Execution Plan",
-          "\nLogicalProject(avg=[/($0, $1)])",
-          "\n  LogicalProject($f0=[CASE(=($1, 0), null:DECIMAL(1000, 0), $0)], $f1=[$1])",
-          "\n    LogicalAggregate(group=[{}], agg#0=[$SUM0($0)], agg#1=[$SUM0($1)])",
-          "\n      LogicalExchange(distribution=[hash])",
-          "\n        LogicalAggregate(group=[{}], agg#0=[$SUM0($0)], agg#1=[COUNT()])",
-          "\n          LogicalProject(col4=[$0], col2=[$1], col3=[$2])",
-          "\n            LogicalFilter(condition=[AND(>=($2, 0), =($1, 'pink floyd'))])",
-          "\n              LogicalTableScan(table=[[a]])",
+          "\nLogicalProject(avg=[/(CASE(=($1, 0), null:DECIMAL(1000, 0), $0), $1)])",

Review Comment:
   This is because I am now doing the pruning/merging of redundant operators in the end and using a RuleCollection. (if that's what you meant)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org