You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/18 16:15:26 UTC
[GitHub] [airflow] patchandpray opened a new pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
patchandpray opened a new pull request #12453:
URL: https://github.com/apache/airflow/pull/12453
Fixes a bug when calling `/api/v1//dags/~/dagRuns/~/taskInstances/list` with `dag_ids` as parameter. The behavior is now as described in the issue as desired. `start_date`, `end_date` and `state` are returned as null when None.
closes: #12306
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-729954429
@ephraimbuddy Can you review?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-730631136
The PR should be OK to be merged with just subset of tests as it does not modify Core of Airflow. The committers might merge it or can add a label 'full tests needed' and re-run it to run all tests if they see it is needed!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb removed a comment on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ashb removed a comment on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-731117734
Fixes a bug when calling `/api/v1/dags/~/dagRuns/~/taskInstances/list` with dag_ids as parameter.
The schema had defined `start_date`, `end_date` and `state` as non-nullable, but they are optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-731118155
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-731117734
Fixes a bug when calling `/api/v1/dags/~/dagRuns/~/taskInstances/list` with dag_ids as parameter.
The schema had defined `start_date`, `end_date` and `state` as non-nullable, but they are optional.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-730625767
This looks good to me @ashb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #12453:
URL: https://github.com/apache/airflow/pull/12453
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-729786385
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] patchandpray commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
patchandpray commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-730438485
@ephraimbuddy I added a unit test that asserts that when TaskInstance properties are nullable (start_date, end_date, state) the respective task_instances are returned in the json response from TaskInstancesBatch endpoint.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ephraimbuddy commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-729986786
Nice!.
This is good and working fine but I think there's need to add unittest to it @patchandpray
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] patchandpray commented on pull request #12453: Fixes list of taskInstances without start_date, end_date and state fa…
Posted by GitBox <gi...@apache.org>.
patchandpray commented on pull request #12453:
URL: https://github.com/apache/airflow/pull/12453#issuecomment-730172871
Sure, I'll look into it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org