You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "rahult-github (via GitHub)" <gi...@apache.org> on 2023/06/29 10:47:07 UTC
[GitHub] [mynewt-nimble] rahult-github opened a new pull request, #1539: nimble/host: Set length correctly in perdioic_set_adv_data
rahult-github opened a new pull request, #1539:
URL: https://github.com/apache/mynewt-nimble/pull/1539
This change sets length field only if data is non NULL, else sets length to zero.
Core 5.4, Vol 4, Part E, section 7.8.62 states
"If Operation is not 0x03 or 0x04 and Advertising_Data_Length is zero, then the Controller shall return the error code Invalid HCI Command Parameters (0x12).."
Current code sets length to size of data. However, to validate above, need to send 0 length . So calculate length only if data is present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rahult-github commented on pull request #1539: nimble/host: Set length correctly in perdioic_set_adv_data
Posted by "rahult-github (via GitHub)" <gi...@apache.org>.
rahult-github commented on PR #1539:
URL: https://github.com/apache/mynewt-nimble/pull/1539#issuecomment-1619953453
> currently ble_gap_periodic_adv_set() assumes that data is always valid and I'm not sure on how this patch would work since *data is dereferenced mutliple times later on in the function
Thanks for pointing this out. I have updated the patch to copy data only if len is valid . ( in the cases where length can be zero )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/host: Set length correctly in perdioic_set_adv_data [mynewt-nimble]
Posted by "sjanc (via GitHub)" <gi...@apache.org>.
sjanc merged PR #1539:
URL: https://github.com/apache/mynewt-nimble/pull/1539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rahult-github commented on pull request #1539: nimble/host: Set length correctly in perdioic_set_adv_data
Posted by "rahult-github (via GitHub)" <gi...@apache.org>.
rahult-github commented on PR #1539:
URL: https://github.com/apache/mynewt-nimble/pull/1539#issuecomment-1706080217
Hi @sjanc , please let me know if there are any more comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org