You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2016/12/23 12:35:54 UTC

Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19005
    https://issues.apache.org/jira/browse/AMBARI-19005


Repository: ambari


Description
-------

Observed an issue that affects earlier releases of HIVE as well. The conf.server directory has hive-site.xml with metastore server password in it.
That directory is only populated on machines with hs2/metastore (the good part).
But the permissions of that directory and the files in it are not restricted, it should be set to 700 (directory) and 600 (files). Currently, it is set to 755 and 644 for dir and files.
I believe intention of creating separate directory was to restrict permissions to only the user hive.
I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 sandboxes, so it seems to affect the corresponding ambari versions as well.


Diffs
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 792aac3 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 298db2a 

Diff: https://reviews.apache.org/r/55002/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160094
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On \u0414\u0435\u043a. 23, 2016, 5:29 \u043f.\u043f., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> -----------------------------------------------------------
> 
> (Updated \u0414\u0435\u043a. 23, 2016, 5:29 \u043f.\u043f.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
>     https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Observed an issue that affects earlier releases of HIVE as well. The conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good part).
> But the permissions of that directory and the files in it are not restricted, it should be set to 700 (directory) and 600 (files). Currently, it is set to 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ffc996c 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b96437d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 799ee39 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8b866d6 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 5ee09f6 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py e00668a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/
-----------------------------------------------------------

(Updated \u0413\u0440\u0443. 23, 2016, 5:29 \u043f\u0456\u0441\u043b\u044f \u043f\u043e\u043b\u0443\u0434\u043d\u044f)


Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-19005
    https://issues.apache.org/jira/browse/AMBARI-19005


Repository: ambari


Description
-------

Observed an issue that affects earlier releases of HIVE as well. The conf.server directory has hive-site.xml with metastore server password in it.
That directory is only populated on machines with hs2/metastore (the good part).
But the permissions of that directory and the files in it are not restricted, it should be set to 700 (directory) and 600 (files). Currently, it is set to 755 and 644 for dir and files.
I believe intention of creating separate directory was to restrict permissions to only the user hive.
I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 sandboxes, so it seems to affect the corresponding ambari versions as well.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py ffc996c 
  ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py af2a05d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b96437d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 799ee39 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8b866d6 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 5ee09f6 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py e00668a 

Diff: https://reviews.apache.org/r/55002/diff/


Testing
-------

mvn clean test


Thanks,

Vitalyi Brodetskyi


Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160077
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 23, 2016, 12:35 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2016, 12:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
>     https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Observed an issue that affects earlier releases of HIVE as well. The conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good part).
> But the permissions of that directory and the files in it are not restricted, it should be set to 700 (directory) and 600 (files). Currently, it is set to 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 792aac3 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 298db2a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>


Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160074
-----------------------------------------------------------


Ship it!




Ship It!

- Dmytro Sen


On \u0414\u0435\u043a. 23, 2016, 12:35 \u043f.\u043f., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> -----------------------------------------------------------
> 
> (Updated \u0414\u0435\u043a. 23, 2016, 12:35 \u043f.\u043f.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
>     https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Observed an issue that affects earlier releases of HIVE as well. The conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good part).
> But the permissions of that directory and the files in it are not restricted, it should be set to 700 (directory) and 600 (files). Currently, it is set to 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py 792aac3 
>   ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py 298db2a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>