You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/07/24 22:25:19 UTC

[GitHub] aaronmarkham commented on a change in pull request #11874: [MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0

aaronmarkham commented on a change in pull request #11874: [MXNET-711] Fixing the version build to show 1.2.1 instead of 1.2.0
URL: https://github.com/apache/incubator-mxnet/pull/11874#discussion_r204930953
 
 

 ##########
 File path: docs/build_version_doc/AddVersion.py
 ##########
 @@ -36,7 +36,7 @@
     tag_list = list()
     with open('tag_list.txt', 'r') as tag_file:
         for line in tag_file:
-            tag_list.append(line.lstrip().rstrip())
+            tag_list.append(line.lstrip().rstrip().replace("0.12.0","0.12.1").replace("1.2.0","1.2.1"))
 
 Review comment:
   As discussed, please move this logic upstream and hook into the Jenkins job's parameters for the list of tags to display. 
   Also, please add comments along the way that make it clear what the differences are between the tags to build and the tags to display.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services