You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/06/08 10:12:19 UTC
[GitHub] [shardingsphere-elastic-job-lite] DoolinMa opened a new pull request #757: make elastic-job-lite-console can package and run
DoolinMa opened a new pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757
Fixes #ISSUSE_ID.
Changes proposed in this pull request:
1.fix start.bat ,it can not run only use ConsoleBootstrap name;
2.now the elastic-job-lite-console can not be package use maven,the error are below
[ERROR] Could not find goal 'assembly' in plugin org.apache.maven.plugins:maven-assembly-plugin:3.0.0 among available goals help, single -> [Help 1]
it should be notify the version of maven-assembly-plugin ,the default version is 3.0.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] tuohai666 commented on pull request #757: make elastic-job-lite-console can package and run
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757#issuecomment-640520681
Why 3.0.0 burst that error? Should we use that beta version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] DoolinMa commented on a change in pull request #757: make elastic-job-lite-console can package and run
Posted by GitBox <gi...@apache.org>.
DoolinMa commented on a change in pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757#discussion_r437125642
##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>2.2-beta-5</version>
Review comment:
thanks!
Add id like <id>console-bin</id> can resolve 2.x
but 3.x have no goal assembly ,the goal should be single
I have test all the version.
I'm trying to use version 3. X
##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>2.2-beta-5</version>
Review comment:
I have tested all the versions，change maven-assembly-plugin version to 3.3.0.
but it should be id in assembly.xml .please check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] tuohai666 merged pull request #757: make elastic-job-lite-console can package and run
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] tuohai666 edited a comment on pull request #757: make elastic-job-lite-console can package and run
Posted by GitBox <gi...@apache.org>.
tuohai666 edited a comment on pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757#issuecomment-640520681
Why 3.0.0 burst that error? Should we use that beta version? Can version 3.1~3.3 fix this problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elastic-job-lite] tuohai666 commented on a change in pull request #757: make elastic-job-lite-console can package and run
Posted by GitBox <gi...@apache.org>.
tuohai666 commented on a change in pull request #757:
URL: https://github.com/apache/shardingsphere-elastic-job-lite/pull/757#discussion_r436682203
##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>2.2-beta-5</version>
Review comment:
Add id like \<id>console-bin\</id> in both <execution> and assembly.xml will resolve this problem.
##########
File path: elastic-job-lite-console/pom.xml
##########
@@ -86,6 +86,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
+ <version>2.2-beta-5</version>
Review comment:
You are right, the goal should be single.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org