You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@netbeans.apache.org by "Svatopluk Dedic (Jira)" <ji...@apache.org> on 2020/09/21 11:24:00 UTC

[jira] [Created] (NETBEANS-4828) Review PayaraDescriptor loader & data object registrations.

Svatopluk Dedic created NETBEANS-4828:
-----------------------------------------

             Summary: Review PayaraDescriptor loader & data object registrations.
                 Key: NETBEANS-4828
                 URL: https://issues.apache.org/jira/browse/NETBEANS-4828
             Project: NetBeans
          Issue Type: Bug
          Components: javaee - DD Editor
    Affects Versions: 12.0
            Reporter: Svatopluk Dedic


During *commit-validation* cleanup, I have removed {{@DataObject.Registration}} for {{org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject}}. 
The registration duplicates the one on {{PayaraDescriptorDataLoader}} and, since it is position-ordered after it is not used during recognition IMHO.
In addition, the registration requires that DataObject has a specific constructor signature, which PayaraDescriptorDataObject does not satisfy: if the registration was selected for DO construction, the creation would fail with reflection exception:

{code:bash}
    [junit] java.lang.NoSuchMethodException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems.FileObj
ect, org.openide.loaders.MultiFileLoader)
    [junit]     at java.lang.Class.getConstructor0(Class.java:3082)
    [junit]     at java.lang.Class.getConstructor(Class.java:1825)
    [junit]     at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:54)
    [junit] Caused: java.lang.IllegalStateException: org.netbeans.modules.payara.eecommon.dd.loader.PayaraDescriptorDataObject.<init>(org.openide.filesystems
.FileObject, org.openide.loaders.MultiFileLoader)
    [junit]     at org.openide.loaders.MimeFactory.<init>(MimeFactory.java:57)
    [junit]     at org.openide.loaders.MimeFactory.layer(MimeFactory.java:77)
    [junit]     at org.openide.loaders.DataLoaderPool.factory(DataLoaderPool.java:641)
    [junit] Caused: java.lang.reflect.InvocationTargetException
{code}

*Please review the registrations*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@netbeans.apache.org
For additional commands, e-mail: commits-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists