You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/05/17 16:55:55 UTC

[GitHub] [echarts] Fritzbox2000 opened a new issue, #17057: [Bug] Quarter in date format returns only up to Quarter 3

Fritzbox2000 opened a new issue, #17057:
URL: https://github.com/apache/echarts/issues/17057

   ### Version
   
   5.3.2
   
   ### Link to Minimal Reproduction
   
   _No response_
   
   ### Steps to Reproduce
   
   1. Using Echarts.time.format() with some date (e.g.12th December 2000) and the format {Q} will return the wrong quarter (in this instance quarter 3
    
   
   ### Current Behavior
   
   Gives Quarters as follows for each month:
   Jan: 1
   Feb: 1
   Mar: 1
   Apr: 1
   May: 2
   Jun: 2
   Jul: 2
   Aug: 2
   Sep: 3
   Oct: 3
   Nov: 3
   Dec: 3
   
   ### Expected Behavior
   
   Should give Quarters as follows for each month:
   Jan: 1
   Feb: 1
   Mar: 1
   Apr: 2
   May: 2
   Jun: 2
   Jul: 3
   Aug: 3
   Sep: 3
   Oct: 4
   Nov: 4
   Dec: 4
   
   ### Environment
   
   _No response_
   
   ### Any additional comments?
   
   The code is in 
   https://github.com/apache/echarts/blob/13c2d062e6bcd49ab6da87eb4032ac01ec9fe467/src/util/time.ts#L116
   (`    const q = Math.floor((M - 1) / 4) + 1;`)
   should be:
   `    const q = Math.floor((M - 1) / 3) + 1;`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia closed issue #17057: [Bug] Quarter in date format returns only up to Quarter 3

Posted by GitBox <gi...@apache.org>.
Ovilia closed issue #17057: [Bug]  Quarter in date format returns only up to Quarter 3
URL: https://github.com/apache/echarts/issues/17057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org