[jira] [Resolved] (REEF-641) NetworkConnectionService should look up a correct end point id with deprecated methods

["Brian Cho (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Cho resolved REEF-641.
----------------------------
       Resolution: Fixed
    Fix Version/s: 0.13

Merged https://github.com/apache/incubator-reef/pull/411

> NetworkConnectionService should look up a correct end point id with deprecated methods
> --------------------------------------------------------------------------------------
>
>                 Key: REEF-641
>                 URL: https://issues.apache.org/jira/browse/REEF-641
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Geon Woo Kim
>            Assignee: Geon Woo Kim
>            Priority: Minor
>             Fix For: 0.13
>
>
> [~yunseong] have found a bug that NCS did not work correctly with deprecated methods. In [REEF-610|https://issues.apache.org/jira/browse/REEF-610], we made {{NetworkConnectionService}} be able to register multiple identifiers by assigning different local end point identifier for every single {{NetworkConnectionFactory}}.  So one container can be looked up by many identifiers that follow the form {{connectionFactoryId}}/{{localEndPointId}}. 
> For example, supposed that there are two evaluators A, B and two connection types Shuffle and GroupComm. Both {{Shuffle}}/{{A}} and {{GroupComm}}/{{A}} can represent the same evaluator A.
> If some {{NetworkConnectionFactory}} are registered by deprecated methods, it should look up {{remoteEndPointId}} without {{connectionFactoryId}}. However, current {{NetworkConnectionFactory}} always looks up other container's address with {{connectionFactoryId}}/{{remoteEndPointId}} regardless of whether they are registered by deprecated methods, or not. We should change it to look up without {{connectionFactoryId}} if the {{NetworkConnectionFactory}} was registered by deprecated method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)