[GitHub] [cordova-ios] erisu edited a comment on pull request #1158: refactor: replace copy-www-build-step script with build phase

[GitBox <gi...@apache.org>]

erisu edited a comment on pull request #1158:
URL: https://github.com/apache/cordova-ios/pull/1158#issuecomment-953759585


   @dpogue I have updated this PR to properly copy the correct content as well as simplify the build process. This PR is strictly focused on copying the app resources to the correct location. 
   
   I have combined the build phases `Copy www` & `Copy config.xml` into one build phase call `Copy Staging Resources`.
   
   The contents of the "Staging" group are, `www` and `config.xml`.
   
   The location of these resources come from:
   
   - `<project-dir>/platforms/ios/www/`
   - `<project-dir>/platforms/ios/<project-name>/config.xml`
   
   And these are what `cordova prepare` generates.
   
   Additionally, the combine build phase is not blindly copying an entire grouping. If users add things to that group, they would still need to update the build phase to include those items to be copied. I think from a Cordova perspective, users should not add anything to this grouping anyways.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org