You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Arpit Singh Pandya (JIRA)" <ji...@apache.org> on 2009/11/16 11:00:40 UTC
[jira] Created: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-3208
URL: https://issues.apache.org/jira/browse/OFBIZ-3208
Project: OFBiz
Issue Type: Bug
Components: order
Affects Versions: Release Branch 9.04, SVN trunk
Reporter: Arpit Singh Pandya
Priority: Minor
Fix For: Release Branch 9.04, SVN trunk
Steps to regenerate the issue :-
1). Create an sales order.
2). Click on "Create As New Order" button available in action block of order view page.
3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
- Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Arpit Singh Pandya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778332#action_12778332 ]
Arpit Singh Pandya commented on OFBIZ-3208:
-------------------------------------------
Sure Ashish, I will look into this too.
Thanks Jacques.
--
Arpit Singh Pandya
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778325#action_12778325 ]
Ashish Vijaywargiya commented on OFBIZ-3208:
--------------------------------------------
Ok cool, Thanks - Arpit please take care of Jacques comment.
FYI, I was using GZ-2644.
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778300#action_12778300 ]
Jacques Le Roux commented on OFBIZ-3208:
----------------------------------------
While I was looking at this I got an NPE and gave up for now
java.lang.NullPointerException
org.ofbiz.order.shoppingcart.ShoppingCart.setItemShipGroupQty(ShoppingCart.java:2030)
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Arpit Singh Pandya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Singh Pandya updated OFBIZ-3208:
--------------------------------------
Attachment: OFBIZ-3208.patch
Here is patch to fix the problem.
--
Arpit Singh Pandya
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3208:
------------------------------------------
Assignee: Ashish Vijaywargiya
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Arpit Singh Pandya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778347#action_12778347 ]
Arpit Singh Pandya commented on OFBIZ-3208:
-------------------------------------------
Hello Jacques,
Can you please give me the steps to reproduce the Problem.
I have tested with the product you specified, but didn't get any error about NPE.
--
Arpit Singh Pandya
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778361#action_12778361 ]
Jacques Le Roux commented on OFBIZ-3208:
----------------------------------------
Hi Arpit, Ashish,
Sorry for bother, it was an order I created recently, I'm not able to reproduce, please forget it.
Thanks
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778322#action_12778322 ]
Jacques Le Roux commented on OFBIZ-3208:
----------------------------------------
Forgot to say that I have not applied the patch when I crossed this NPE
And forgot to send this comment for one hour now :(
Ashish,
This order contains a GZ-BASKET (and associated promotions) I can't see any other specificities
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-3208.
--------------------------------------
Resolution: Fixed
Thanks Arpit for the contribution - Done at trunk r882454 & RB9.04 at r882456.
--
Ashish Vijaywargiya
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch, OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Arpit Singh Pandya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arpit Singh Pandya updated OFBIZ-3208:
--------------------------------------
Attachment: OFBIZ-3208.patch
Uploading the updated patch.This patch will resolve the following Issues
1) Shipping and Handling Charges are added twice in new order amount.
2) Sales Tax are added twice in new order amount.
3) Add extra tax on shipping and handling charges for new order.
4) When click on "Create as New Order" Link, it is Giving NPE on some Promotion (Happy Hour
Promotion 9020).
5) Click on "Edit Items" Link and then "Update" Link it is it is Giving NPE on some Promotion (Happy
Hour Promotion 9020).
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch, OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-3208) On order view page when clicking on
"Create As New Order", the adjustments Shipping and Handling and Sales Tax
are duplicated.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778315#action_12778315 ]
Ashish Vijaywargiya commented on OFBIZ-3208:
--------------------------------------------
Hello Jacuqes,
Can you please provide steps to reproduce this NPE?
Is this error occurred for you after applying Arpit's patch?
I am not getting any such error after clicking "Create as New Order" button and creating order from their.
--
Ashish
> On order view page when clicking on "Create As New Order", the adjustments Shipping and Handling and Sales Tax are duplicated.
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-3208
> URL: https://issues.apache.org/jira/browse/OFBIZ-3208
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: Release Branch 9.04, SVN trunk
> Reporter: Arpit Singh Pandya
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: Release Branch 9.04, SVN trunk
>
> Attachments: OFBIZ-3208.patch
>
>
> Steps to regenerate the issue :-
> 1). Create an sales order.
> 2). Click on "Create As New Order" button available in action block of order view page.
> 3). It will navigate to finalize order page, click on "continue" link, it will navigate to Order confirmation page click on "Create Order" Link.
> Now you can see that the adjustment(Shipping and Handling Charges and Sales Tax) are duplicated and also added in order total.
> - Arpit Singh Pandya
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.