You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/12/15 07:26:11 UTC
[GitHub] [cloudstack] slavkap opened a new issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
slavkap opened a new issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g., API, VR, VPN, UI, etc.
-->
~~~
Primary storage - excluding Ceph/non managed NFS
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
main and older versions
~~~
##### CONFIGURATION
<!--
Information about the configuration if relevant, e.g. basic network, advanced networking, etc. N/A otherwise
-->
##### OS / ENVIRONMENT
<!--
Information about the environment if relevant, N/A otherwise
-->
OS - CentOS7
hypervisor - KVM
mgmt/agent version - 4.16.0.0
##### SUMMARY
<!-- Explain the problem/feature briefly -->
When you put the primary storage on Maintenance mode and restart the agent, the storage will be removed from the storage adaptor's map. This causes NullPointerException when collecting the storage statistics. Probably the problem is for all storage pools which don't use `LibvirtStorageAdaptor` - e.g. Linstor, PowerFlex, StorPool
This does not affect Ceph and non managed NFS
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
~~~
set storage.stats.interval on short interval
enable storage maintenance mode
restart the agents
~~~
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
collect or don't the storage stats on pools on Maintenance mode
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
2021-12-15 08:31:03,586 DEBUG [cloud.agent.Agent] (agentRequest-Handler-3:null) (logid:552801e3) Processing command: com.cloud.agent.api.GetStorageStatsCommand
2021-12-15 08:31:03,586 WARN [cloud.agent.Agent] (agentRequest-Handler-3:null) (logid:552801e3) Caught:
java.lang.NullPointerException
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetStorageStatsCommandWrapper.execute(LibvirtGetStorageStatsCommandWrapper.java:40)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtGetStorageStatsCommandWrapper.execute(LibvirtGetStorageStatsCommandWrapper.java:32)
at com.cloud.hypervisor.kvm.resource.wrapper.LibvirtRequestWrapper.execute(LibvirtRequestWrapper.java:78)
at com.cloud.hypervisor.kvm.resource.LibvirtComputingResource.executeRequest(LibvirtComputingResource.java:1768)
at com.cloud.agent.Agent.processRequest(Agent.java:661)
at com.cloud.agent.Agent$AgentRequestHandler.doTask(Agent.java:1079)
at com.cloud.utils.nio.Task.call(Task.java:83)
at com.cloud.utils.nio.Task.call(Task.java:29)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
2021-12-15 08:31:03,588 DEBUG [cloud.agent.Agent] (agentRequest-Handler-3:null) (logid:552801e3) Seq 60-4602115869219225621: { Ans: , MgmtId: 2199191159196, via: 60, Ver: v1, Flags: 10, [{"com.cloud.agent.api.Answer":{"result":"false","details":"java.lang.NullPointerException
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-995948121
@rp-, @svenvogel, may I ask you if you have time to check if this affects Linstor and SolidFire?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti closed issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
sureshanaparti closed issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007340177
@slavkap is this an old issue or a regression?
I suggest #5841 as a solution but might be missing something. Can you test that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007342809
Hey @DaanHoogland, this PR seems to fix the problem. I'll test it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rp- commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
rp- commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-999587810
sorry, was busy with another task.
But yes I can confirm this also effects(and I can reproduce the NPE) the linstor driver
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1009647171
Fixed in #5841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
slavkap commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007342809
Hey @DaanHoogland, this PR seems to fix the problem. I'll test it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-999293041
> @rp-, @svenvogel, may I ask you if you have time to check if this affects Linstor and SolidFire?
ping @rp- , @svenvogel can you check and confirm this. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap edited a comment on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
slavkap edited a comment on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007342809
Hey @DaanHoogland, this PR seems to fix the problem. The issue is old, I've seen it from 4.11.3.0 to main. I'll test it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007340177
@slavkap is this an old issue or a regression?
I suggest #5841 as a solution but might be missing something. Can you test that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] slavkap edited a comment on issue #5775: KVM: probable problem with storage stats when storage is put on maintenance
Posted by GitBox <gi...@apache.org>.
slavkap edited a comment on issue #5775:
URL: https://github.com/apache/cloudstack/issues/5775#issuecomment-1007342809
Hey @DaanHoogland, this PR seems to fix the problem. The issue is old, I've seen it from 4.11.3.0 to main. I'll test it, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org