[jira] [Commented] (SPARK-43137) Improve ArrayInsert if the position is foldable and equals to zero.

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-43137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17713492#comment-17713492 ] 

ASF GitHub Bot commented on SPARK-43137:
----------------------------------------

User 'beliefer' has created a pull request for this issue:
https://github.com/apache/spark/pull/40833

> Improve ArrayInsert if the position is foldable and equals to zero.
> -------------------------------------------------------------------
>
>                 Key: SPARK-43137
>                 URL: https://issues.apache.org/jira/browse/SPARK-43137
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 3.5.0
>            Reporter: jiaan.geng
>            Priority: Major
>
> We want make array_prepend reuse the implementation of array_insert, but it seems a bit performance worse if the position is foldable and equals to zero.
> The reason is that always do the check for position is negative or positive, and the code is too long. Too long code will lead to JIT failed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org