You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "014-code (via GitHub)" <gi...@apache.org> on 2026/06/11 08:13:02 UTC
[PR] [ISSUE #9796] Support getConsumerRunningInfo in proxy cluster mode [rocketmq]
014-code opened a new pull request, #10480:
URL: https://github.com/apache/rocketmq/pull/10480
### Which Issue(s) This PR Fixes
Fixes #9796
### Brief Description
This PR supports `GET_CONSUMER_RUNNING_INFO` in proxy cluster mode.
Previously, `mqadmin consumerStatus` against the proxy cluster remoting port failed with:
`request type 307 not supported`
### Root Cause
The proxy remoting server did not register `RequestCode.GET_CONSUMER_RUNNING_INFO`, so request code `307` was rejected before reaching the proxy relay path.
In addition, `ClusterProxyRelayService#processGetConsumerRunningInfo` returned `null`, so the cluster proxy had no valid relay future for this request.
### How Was This Fixed?
- Register `RequestCode.GET_CONSUMER_RUNNING_INFO` in `RemotingProtocolServer`.
- Add request handling in `ConsumerManagerActivity`.
- Locate the target consumer channel by `consumerGroup` and `clientId`.
- Relay the request through the proxy-managed `ProxyChannel`.
- Encode and write `ConsumerRunningInfo` back to the original admin request.
- Make `ClusterProxyRelayService#processGetConsumerRunningInfo` return a `CompletableFuture` instead of `null`.
### Tests
Added test file:
`proxy/src/test/java/org/apache/rocketmq/proxy/remoting/activity/ConsumerManagerActivityTest.java`
Verified the following test methods passed in IDEA:
- `testGetConsumerRunningInfo`
- `testGetConsumerRunningInfoWhenConsumerNotOnline`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9796] Support getConsumerRunningInfo in proxy cluster mode [rocketmq]
Posted by "014-code (via GitHub)" <gi...@apache.org>.
014-code commented on PR #10480:
URL: https://github.com/apache/rocketmq/pull/10480#issuecomment-4757815537
Could a maintainer help approve the pending workflows for this PR? All requested changes have been addressed and tests are ready to run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #9796] Support getConsumerRunningInfo in proxy cluster mode [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10480:
URL: https://github.com/apache/rocketmq/pull/10480#issuecomment-4706698623
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/10480?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `75.75758%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.05%. Comparing base ([`50ae7c5`](https://app.codecov.io/gh/apache/rocketmq/commit/50ae7c50930798aced54c4c24467f847eb684aed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e6cd8d0`](https://app.codecov.io/gh/apache/rocketmq/commit/e6cd8d0c5700a75939846ec8fad7d3b75a65fe28?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 18 commits behind head on develop.
| [Files with missing lines](https://app.codecov.io/gh/apache/rocketmq/pull/10480?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...oxy/remoting/activity/ConsumerManagerActivity.java](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fremoting%2Factivity%2FConsumerManagerActivity.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL2FjdGl2aXR5L0NvbnN1bWVyTWFuYWdlckFjdGl2aXR5LmphdmE=) | 84.00% | [2 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/rocketmq/proxy/service/relay/ProxyChannel.java](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Frelay%2FProxyChannel.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvcmVsYXkvUHJveHlDaGFubmVsLmphdmE=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...ocketmq/proxy/remoting/RemotingProtocolServer.java](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fremoting%2FRemotingProtocolServer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3JlbW90aW5nL1JlbW90aW5nUHJvdG9jb2xTZXJ2ZXIuamF2YQ==) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../proxy/service/relay/ClusterProxyRelayService.java](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&filepath=proxy%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Frocketmq%2Fproxy%2Fservice%2Frelay%2FClusterProxyRelayService.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHJveHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Byb3h5L3NlcnZpY2UvcmVsYXkvQ2x1c3RlclByb3h5UmVsYXlTZXJ2aWNlLmphdmE=) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/10480?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #10480 +/- ##
=============================================
+ Coverage 47.98% 48.05% +0.07%
- Complexity 13291 13316 +25
=============================================
Files 1377 1377
Lines 100644 100693 +49
Branches 12995 13001 +6
=============================================
+ Hits 48297 48393 +96
+ Misses 46406 46357 -49
- Partials 5941 5943 +2
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/rocketmq/pull/10480?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org