You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Prashant Satam <pr...@gmail.com> on 2023/07/26 11:43:28 UTC
Review Request 74528: RANGER-4323: GDS: Need new api to get details of dataset listing page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4323
https://issues.apache.org/jira/browse/RANGER-4323
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
security-admin/src/main/java/org/apache/ranger/view/VXRangerPrincipalView.java PRE-CREATION
Diff: https://reviews.apache.org/r/74528/diff/1/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
> On Aug. 8, 2023, 12:37 p.m., Ramachandran Krishnan wrote:
> > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/74528/diff/6/?file=2278066#file2278066line130>
> >
> > Is it possible to move this native query into jpa_named_queries.xml and passing the binding parameter
can do that but will require 3 seperate JPA queries as UNION is not supported in JPA query
- Prashant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225634
-----------------------------------------------------------
On Aug. 7, 2023, 9:12 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2023, 9:12 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
> security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
>
>
> Diff: https://reviews.apache.org/r/74528/diff/6/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Madhan Neethiraj <ma...@apache.org>.
> On Aug. 8, 2023, 12:37 p.m., Ramachandran Krishnan wrote:
> > security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java
> > Lines 130 (patched)
> > <https://reviews.apache.org/r/74528/diff/6/?file=2278066#file2278066line130>
> >
> > Is it possible to move this native query into jpa_named_queries.xml and passing the binding parameter
>
> Prashant Satam wrote:
> can do that but will require 3 seperate JPA queries as UNION is not supported in JPA query
Consider using a VIEW to get around JPA limitation on use of UNION.
- Madhan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225634
-----------------------------------------------------------
On Aug. 7, 2023, 9:12 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2023, 9:12 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
> security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
>
>
> Diff: https://reviews.apache.org/r/74528/diff/6/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Ramachandran Krishnan <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225634
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java
Lines 130 (patched)
<https://reviews.apache.org/r/74528/#comment314104>
Is it possible to move this native query into jpa_named_queries.xml and passing the binding parameter
- Ramachandran Krishnan
On Aug. 7, 2023, 9:12 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2023, 9:12 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
> security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
>
>
> Diff: https://reviews.apache.org/r/74528/diff/6/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225672
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 23, 2023, 5:35 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 23, 2023, 5:35 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql b4e3f57b8
> security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6b82aead4
> security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 1f282948b
> security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
> security-admin/src/main/java/org/apache/ranger/entity/view/VXXPrincipal.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 4398764ae
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 59a20a25e
>
>
> Diff: https://reviews.apache.org/r/74528/diff/7/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 23, 2023, 5:35 a.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql b4e3f57b8
security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql 6b82aead4
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 1f282948b
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
security-admin/src/main/java/org/apache/ranger/entity/view/VXXPrincipal.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 4398764ae
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 59a20a25e
Diff: https://reviews.apache.org/r/74528/diff/7/
Changes: https://reviews.apache.org/r/74528/diff/6-7/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 7, 2023, 9:12 a.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
Diff: https://reviews.apache.org/r/74528/diff/6/
Changes: https://reviews.apache.org/r/74528/diff/5-6/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 3, 2023, 12:48 p.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java 08e96f839
security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 4e5b692b5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 59a20a25e
Diff: https://reviews.apache.org/r/74528/diff/5/
Changes: https://reviews.apache.org/r/74528/diff/4-5/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 3, 2023, 11:37 a.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java 08e96f839
security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 4e5b692b5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 59a20a25e
Diff: https://reviews.apache.org/r/74528/diff/4/
Changes: https://reviews.apache.org/r/74528/diff/3-4/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 3, 2023, 11:28 a.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 23650c8d5
security-admin/src/main/java/org/apache/ranger/db/XXGroupDao.java 08e96f839
security-admin/src/main/java/org/apache/ranger/db/XXRoleDao.java 4e5b692b5
security-admin/src/main/java/org/apache/ranger/db/XXUserDao.java 283d84fe1
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
Diff: https://reviews.apache.org/r/74528/diff/3/
Changes: https://reviews.apache.org/r/74528/diff/2-3/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
> On Aug. 1, 2023, 4:41 p.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
> > Lines 530 (patched)
> > <https://reviews.apache.org/r/74528/diff/2/?file=2278018#file2278018line530>
> >
> > Following calls would result in at least 3 database queries (or 6 queries when getCount=true):
> > - getUsersLookup()
> > - getGroupsLookup()
> > - roleStore.getRoles()
> >
> > Is it possible to retrieve user/group/role names in a single query, with something like the following:
> >
> > (SELECT user_name AS principal_name, 0 AS principal_type FROM x_user WHERE user_name LIKE 'r%' AND is_visible = 1 ORDER BY user_name LIMIT 5)
> > UNION
> > (SELECT group_name AS principal_name, 1 AS principal_type FROM x_group WHERE group_name LIKE 'r%' AND is_visible = 1 ORDER BY group_name LIMIT 5)
> > UNION
> > (SELECT name AS principal_name, 2 AS principal_type FROM x_role WHERE name LIKE 'r%' ORDER BY name LIMIT 5)
> > ORDER BY principal_name
> > LIMIT 5;
was not able to implement UNION in case of JPA Query so added 3 seperate JPA queries to fetch Name feild List from user,group,role tables
- Prashant
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225621
-----------------------------------------------------------
On Aug. 1, 2023, 7:07 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2023, 7:07 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
>
>
> Diff: https://reviews.apache.org/r/74528/diff/2/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225621
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 530 (patched)
<https://reviews.apache.org/r/74528/#comment314101>
Following calls would result in at least 3 database queries (or 6 queries when getCount=true):
- getUsersLookup()
- getGroupsLookup()
- roleStore.getRoles()
Is it possible to retrieve user/group/role names in a single query, with something like the following:
(SELECT user_name AS principal_name, 0 AS principal_type FROM x_user WHERE user_name LIKE 'r%' AND is_visible = 1 ORDER BY user_name LIMIT 5)
UNION
(SELECT group_name AS principal_name, 1 AS principal_type FROM x_group WHERE group_name LIKE 'r%' AND is_visible = 1 ORDER BY group_name LIMIT 5)
UNION
(SELECT name AS principal_name, 2 AS principal_type FROM x_role WHERE name LIKE 'r%' ORDER BY name LIMIT 5)
ORDER BY principal_name
LIMIT 5;
- Madhan Neethiraj
On Aug. 1, 2023, 7:07 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2023, 7:07 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4325
> https://issues.apache.org/jira/browse/RANGER-4325
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
>
>
> Diff: https://reviews.apache.org/r/74528/diff/2/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>
Re: Review Request 74528: RANGER-4325: GDS: Need api for collective search of user/group/roles
Posted by Prashant Satam <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/
-----------------------------------------------------------
(Updated Aug. 1, 2023, 7:07 a.m.)
Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
Summary (updated)
-----------------
RANGER-4325: GDS: Need api for collective search of user/group/roles
Bugs: RANGER-4325
https://issues.apache.org/jira/browse/RANGER-4325
Repository: ranger
Description
-------
We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
Diff: https://reviews.apache.org/r/74528/diff/2/
Changes: https://reviews.apache.org/r/74528/diff/1-2/
Testing
-------
We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
Thanks,
Prashant Satam
Re: Review Request 74528: RANGER-4323: GDS: Need new api to get details of dataset listing page
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74528/#review225616
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 523 (patched)
<https://reviews.apache.org/r/74528/#comment314099>
"/user/groups/roles" => "/lookup/principals"
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java
Lines 525 (patched)
<https://reviews.apache.org/r/74528/#comment314100>
RangerAPIList.GET_GROUPS_LOOKUP => RangerAPIList.GET_PRINCIPALS_LOOKUP
security-admin/src/main/java/org/apache/ranger/view/VXRangerPrincipalView.java
Lines 21 (patched)
<https://reviews.apache.org/r/74528/#comment314098>
Please consider using org.apache.ranger.plugin.model.RangerPrincipal instead of introducing this new class VXRangerPrincipalView.
- Madhan Neethiraj
On July 26, 2023, 11:43 a.m., Prashant Satam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74528/
> -----------------------------------------------------------
>
> (Updated July 26, 2023, 11:43 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj and Subhrat Chaudhary.
>
>
> Bugs: RANGER-4323
> https://issues.apache.org/jira/browse/RANGER-4323
>
>
> Repository: ranger
>
>
> Description
> -------
>
> We get users,groups,roles all we get in response from one API (/xusers/users/groups/roles) we can also pass Query Params like name,isVisible Also we can PartialSearch Name for users,groups,roles
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 9a2253a3d
> security-admin/src/main/java/org/apache/ranger/view/VXRangerPrincipalView.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/74528/diff/1/
>
>
> Testing
> -------
>
> We get users,groups,roles combined in response from API (/xusers/users/groups/roles) we can pass query params like name(PartialSearch Available),isVisible to filter the users,groups,roles we get in response
>
>
> Thanks,
>
> Prashant Satam
>
>