[jira] Commented: (MNG-2676) maven-dependency-analyser shared component & plugin

["Joerg Schaible (JIRA)" <ji...@codehaus.org>]

    [ http://jira.codehaus.org/browse/MNG-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_85973 ] 

Joerg Schaible commented on MNG-2676:
-------------------------------------

Hi Mark,

looks great! A real help to identify the used deps. Biggest problem though are the indirect deps that are simply discovered since they implement some kind of interface as it is supported by the SPI spec of the JDK or dependency injection frameworks like PicoContainer or Spring. But I guess there's always room for improvement. The analyser may have a SPI on its own for different implementations identifying indirect deps by looking for META-INF/services or grokking the Spring config.

All of this should be integrated into the dependencies plugin though, but I think you had that in mind anyway.

- Jörg

BTW: The analyser does not compile/run with JDK 1.4:

$ diff maven-dependency-analyser/src/main/java/org/apache/maven/shared/dependency/analyser/ClassFileVisitorUtils.java maven-dependency-analyser.14/src/main/java/org/apache/maven/shared/dependency/analyser/ClassFileVisitorUtils.java
22a23
> import java.net.URI;
60c61
<                 File file = new File( url.toURI().getPath() );
---
>                 File file = new File( new URI( url.toString() ).getPath() );
73c74
<                 throw new IllegalArgumentException( "Cannot accept visitor on URL: " + url, exception );
---
>                 throw ( IllegalArgumentException )( new IllegalArgumentException( "Cannot accept visitor on URL: " + url ).initCause( exception ) );


> maven-dependency-analyser shared component & plugin
> ---------------------------------------------------
>
>                 Key: MNG-2676
>                 URL: http://jira.codehaus.org/browse/MNG-2676
>             Project: Maven 2
>          Issue Type: New Feature
>          Components: Dependencies
>    Affects Versions: 2.0.4
>            Reporter: Mark Hobson
>         Assigned To: Joakim Erdfelt
>         Attachments: maven-dependency-analyser-plugin.zip, maven-dependency-analyser.zip
>
>
> A shared component and plugin to analyse project dependencies as described in the thread:
> http://www.mail-archive.com/dev@maven.apache.org/msg61432.html
> Javadoc and tests to come when I get some more free time ;)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira