You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by "Phillippko (via GitHub)" <gi...@apache.org> on 2024/05/20 13:37:23 UTC

[PR] IGNITE-22282 CLI for disaster recovery: restart-partitions [ignite-3]

Phillippko opened a new pull request, #3792:
URL: https://github.com/apache/ignite-3/pull/3792

https://issues.apache.org/jira/browse/IGNITE-22282

Thank you for submitting the pull request.

To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:

### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation. Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios, happy/edge cases. Tests are effective in terms of execution time and resources.

### Notes
- [Apache Ignite Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] IGNITE-22282 CLI for disaster recovery: restart-partitions [ignite-3]

Posted by "rpuch (via GitHub)" <gi...@apache.org>.

rpuch commented on code in PR #3792:
URL: https://github.com/apache/ignite-3/pull/3792#discussion_r1612897043


##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/call/recovery/restart/RestartPartitionsCall.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.internal.cli.call.recovery.restart;
+
+import jakarta.inject.Singleton;
+import org.apache.ignite.internal.cli.core.call.Call;
+import org.apache.ignite.internal.cli.core.call.DefaultCallOutput;
+import org.apache.ignite.internal.cli.core.exception.IgniteCliApiException;
+import org.apache.ignite.internal.cli.core.rest.ApiClientFactory;
+import org.apache.ignite.rest.client.api.RecoveryApi;
+import org.apache.ignite.rest.client.invoker.ApiException;
+import org.apache.ignite.rest.client.model.RestartPartitionsRequest;
+
+/** Call to restart partitions. */
+@Singleton
+public class RestartPartitionsCall implements Call<RestartPartitionsCallInput, String> {
+    private final ApiClientFactory clientFactory;
+
+    public RestartPartitionsCall(ApiClientFactory clientFactory) {
+        this.clientFactory = clientFactory;
+    }
+
+    @Override
+    public DefaultCallOutput<String> execute(RestartPartitionsCallInput input) {
+        RecoveryApi client = new RecoveryApi(clientFactory.getClient(input.clusterUrl()));
+
+        RestartPartitionsRequest command = new RestartPartitionsRequest();
+
+        command.setPartitionIds(input.partitionIds());
+        command.setNodeNames(input.nodeNames());
+        command.setTableName(input.tableName().trim());
+        command.setZoneName(input.zoneName().trim());
+        command.setPurge(input.purge());
+
+        try {
+            client.restartPartitions(command);
+
+            return DefaultCallOutput.success(
+                    "Restarting partitions with" + (input.purge() ? ""  : "out") + " cleanup."

Review Comment:
   I would expect the CLI command to complete when the response is returned, which happens when future completes. It seems that this has to be verified.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org