[GitHub] [helix] i3wangyi commented on a change in pull request #510: Fixing rebalance cache issue and stablize the tests.

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #510: Fixing rebalance cache issue and stablize the tests.
URL: https://github.com/apache/helix/pull/510#discussion_r334666880
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
 ##########
 @@ -216,6 +217,11 @@ public void close() {
               itemKeys.addAll(getChangeDetector().getRemovalsByType(changeType));
               return itemKeys;
             }));
+    // Filter for the items that have content changed.
+    clusterChanges =
 
 Review comment:
   cannot you filter in line 211 or inside change detector? Another round of for loop of everything seems wasted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org