You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/23 02:12:01 UTC
[GitHub] [druid] harshpreet93 opened a new pull request #10059: retry 500 and 503 errors against kinesis
harshpreet93 opened a new pull request #10059:
URL: https://github.com/apache/druid/pull/10059
<!-- Thanks for trying to help us make Apache Druid be the best it can be! Please fill out as much of the following information as is possible (where relevant, and remove it when irrelevant) to help make the intention and scope of this PR clear in order to ease review. -->
Fixes part of https://support.imply.io/hc/en-us/requests/5701
### Description
We ran into an issue whereby a 500 when getting records from kinesis would cause the thread to stop until the end of `taskDuration`. This would cause our ingestion to fall behind. We filed a support ticket with AWS regarding 500 and were basically told that those should be retried by the client and they should be expected in the normal operation of Kinesis. The same advice is echoed at https://aws.amazon.com/premiumsupport/knowledge-center/kinesis-data-stream-500-error/
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
jon-wei commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-648409614
@harshpreet93 Let's add that additional fix to this PR, since they're related
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] harshpreet93 commented on pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
harshpreet93 commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-648464806
@jon-wei I'm fine with leaving it without unit test coverage for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] harshpreet93 commented on pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
harshpreet93 commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-648374960
> LGTM, thanks for the fix!
thanks @jon-wei , it looks like the code at https://github.com/apache/druid/blob/master/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java#L802-L812 can also use the same treatment since it's also calling getRecords and it only retries ProvisionedThroughputExceededException, but all 500 and 503 errors should be retried there as well right? Should I put a fix to that in a follow up PR or attach it to this one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei merged pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
jon-wei merged pull request #10059:
URL: https://github.com/apache/druid/pull/10059
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jon-wei commented on pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
jon-wei commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-648464185
For the test coverage failures:
- I think `isServiceExceptionRecoverable` has enough coverage
- For the change in `getSequenceNumber`, it looks like we don't have any existing unit tests that cover the case where the record supplier throws an exception there, so it's up to you if you want to address that, I'm fine with merging this without, I can look into adding one later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #10059: retry 500 and 503 errors against kinesis
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #10059:
URL: https://github.com/apache/druid/pull/10059#issuecomment-680177897
likely fixes #8615
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org