You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cnabro (via GitHub)" <gi...@apache.org> on 2023/08/08 05:27:15 UTC
[GitHub] [superset] cnabro opened a new pull request, #24911: fix(logs): increase json field for logs table
cnabro opened a new pull request, #24911:
URL: https://github.com/apache/superset/pull/24911
### SUMMARY
- Increase json field for logs table. (Text to MediumText)
- When insert logs while imports a specific dashboard, An error occured.
```
(MySQLdb._exceptions.DataError) (1406, "Data too long for column 'json' at row 1")
[SQL: INSERT INTO logs (`action`, user_id, dashboard_id, slice_id, json, dttm, duration_ms, referrer) VALUES (%s, %s, %s, %s, %s, %s, %s, %s)]
[parameters: ('copy_dash', '1', 9, 0, '{"path": "/superset/copy_dash/9/", "data": "{\\"certified_by\\":\\"\\",\\"certification_details\\":\\"\\",\\"css\\":\\"\\",\\"dashboard_title\\":\\"G ... (171666 characters truncated) ... BS\\"}},\\"filter_scopes\\":\\"{}\\"}", "url_rule": "/superset/copy_dash/<int:dashboard_id>/", "object_ref": "Superset.copy_dash", "dashboard_id": 9}', datetime.datetime(2023, 8, 7, 6, 50, 6, 897685), 6474, '[http://__/superset/dashboard/9/?native_filters_key=A27QtFLKT95Qdd0X-h4KkTLZTBhOslCg0Jshcisx4A8FM71hI_Ae6pBdTc4ac94f')](http://__/superset/dashboard/9/?native_filters_key=A27QtFLKT95Qdd0X-h4KkTLZTBhOslCg0Jshcisx4A8FM71hI_Ae6pBdTc4ac94f%27))]
```
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
```
0769ef90fddd -> 2e826adca42c (head), Fix schema for log
ee179a490af9 -> 0769ef90fddd, Fix schema perm for datasets
e0f6f91c2055 -> ee179a490af9, deckgl-path-width-units
bf646a0c1501 -> e0f6f91c2055, create_user_favorite_table
a23c6f8b1280 -> bf646a0c1501, json_metadata
```
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [x] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [x] Migration is atomic, supports rollback & is backwards-compatible
- [x] Confirm DB migration upgrade and downgrade tested
- [x] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24911: fix(logs): increase json field for logs table
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24911:
URL: https://github.com/apache/superset/pull/24911#issuecomment-1738346700
@john-bodley Ok. I'll give you another PR 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24911: fix(logs): increase json field for logs table
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24911:
URL: https://github.com/apache/superset/pull/24911#issuecomment-1668937293
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24911](https://app.codecov.io/gh/apache/superset/pull/24911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (12c57fe) into [master](https://app.codecov.io/gh/apache/superset/commit/85a7d5cb3ebe833cfc2980f0846f15bb7ce1dd01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (85a7d5c) will **decrease** coverage by `10.67%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 12c57fe differs from pull request most recent head 0fb7049. Consider uploading reports for the commit 0fb7049 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24911 +/- ##
===========================================
- Coverage 69.00% 58.33% -10.67%
===========================================
Files 1906 1906
Lines 74134 74134
Branches 8208 8208
===========================================
- Hits 51153 43244 -7909
- Misses 20858 28767 +7909
Partials 2123 2123
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `54.07% <ø> (ø)` | |
| python | `61.05% <ø> (-22.32%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `55.05% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 294 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24911/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24911: fix(logs): increase json field for logs table
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24911:
URL: https://github.com/apache/superset/pull/24911#issuecomment-1670005939
@cnabro thanks for the change. Would you mind also authoring a follow up PR which adds a line record to `UPDATING.md` which states that downtime is likely required in order to run this migration? A DDL operation (which locks the table) on the heavily used `logs` table will likely result in the service being inoperable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] cnabro commented on pull request #24911: fix(logs): increase json field for logs table
Posted by "cnabro (via GitHub)" <gi...@apache.org>.
cnabro commented on PR #24911:
URL: https://github.com/apache/superset/pull/24911#issuecomment-1670783916
@john-bodley Thank you. I'd added some notices in this PR (https://github.com/apache/superset/pull/24923).
And I'd added descriptions for estimated times for this migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda merged pull request #24911: fix(logs): increase json field for logs table
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda merged PR #24911:
URL: https://github.com/apache/superset/pull/24911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] john-bodley commented on pull request #24911: fix(logs): increase json field for logs table
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #24911:
URL: https://github.com/apache/superset/pull/24911#issuecomment-1737549697
@cnabro looking over your PR I noticed that you didn't actually update the SQLAlchemy [model definition](https://github.com/apache/superset/blob/1716b9f8f68c7abe4c1a082e11ccdb26dbe6a3db/superset/models/core.py#L990). Would you mind authoring a follow up PR to include the model change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org