You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2023/01/01 04:08:23 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #1214: Refactoring: check function return Status marked as [[nodiscard]]

PragmaTwice commented on PR #1214:
URL: https://github.com/apache/incubator-kvrocks/pull/1214#issuecomment-1368346557

   Great changes. Since all warning is fixed, could you modify the CMakeFiles to make the warning as error? You can just follow this TODO, and put `-Werror=unused-result` to L181.
   
   https://github.com/apache/incubator-kvrocks/blob/09d3d18dd9d4e2afebdda13560a8de392b0540d1/CMakeLists.txt#L180-L181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org