You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "pegasas (via GitHub)" <gi...@apache.org> on 2024/05/27 03:16:31 UTC
[PR] [Bug] [Build] Fix build [dolphinscheduler]
pegasas opened a new pull request, #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
fix: https://github.com/apache/dolphinscheduler/issues/16074
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas closed pull request #16075: Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3
URL: https://github.com/apache/dolphinscheduler/pull/16075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075#issuecomment-2132595602
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16075) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16075&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=16075&resolutions=WONTFIX)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=16075&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=16075&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=16075)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075#issuecomment-2132591365
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/16075?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 40.65%. Comparing base [(`fb9172c`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/fb9172cce89df3b89b2aeab4d48c404625aa19f6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4bd1de8`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/4bd1de808c93491bd29184eabf18bb638d8126cb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: **Current head 4bd1de8 differs from pull request most recent head ccb6b77**
>
> Please [upload](https://docs.codecov.com/docs/codecov-uploader) reports for the commit ccb6b77 to get more accurate results.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #16075 +/- ##
============================================
- Coverage 40.66% 40.65% -0.01%
+ Complexity 5225 5224 -1
============================================
Files 1380 1380
Lines 46009 46009
Branches 4919 4919
============================================
- Hits 18709 18706 -3
- Misses 25376 25378 +2
- Partials 1924 1925 +1
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/16075?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075#discussion_r1615435575
##########
dolphinscheduler-storage-plugin/dolphinscheduler-storage-s3/pom.xml:
##########
@@ -38,6 +38,12 @@
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.dolphinscheduler</groupId>
+ <artifactId>dolphinscheduler-aws-authentication</artifactId>
+ <version>${project.version}</version>
+ </dependency>
+
<dependency>
Review Comment:
Please remove the `aws-java-sdk-s3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on PR #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075#issuecomment-2132596571
any similar issue could refer to https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/zh/guide/resource/configuration.md?plain=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add dolphinscheduler-aws-authentication dependency in dolphinscheduler-storage-s3 [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #16075:
URL: https://github.com/apache/dolphinscheduler/pull/16075#issuecomment-2132595982
Please retry analysis of this Pull-Request directly on SonarCloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org