You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Brian Hulette (Jira)" <ji...@apache.org> on 2020/01/10 23:50:00 UTC
[jira] [Commented] (BEAM-9075) Join re-ordering doesn't work for
ZetaSQL
[ https://issues.apache.org/jira/browse/BEAM-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17013274#comment-17013274 ]
Brian Hulette commented on BEAM-9075:
-------------------------------------
In order to disable struct flattening in Calcite we need to make this line [1] optional. According to [~amaliujia] [2] we can comment out that line and run calcite tests to find 25 test failures pointing us to the rules that need to be fixed.
[1] https://github.com/apache/calcite/blob/master/core/src/main/java/org/apache/calcite/prepare/PlannerImpl.java#L257
[2] https://lists.apache.org/thread.html/89e37ebf18aac1f1783c2affb3d2162231e10889c7c4d11cded325c7%40%3Cdev.calcite.apache.org%3E
> Join re-ordering doesn't work for ZetaSQL
> -----------------------------------------
>
> Key: BEAM-9075
> URL: https://issues.apache.org/jira/browse/BEAM-9075
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql-zetasql
> Affects Versions: 2.17.0
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Join re-ordering can actually break queries in the ZetaSQL planner because Calcite's JoinCommuteRule doesn't work when schemas have nested fields. It only adjusts RexInputRef nodes and not RexFieldAccess.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)