You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2019/10/01 21:03:35 UTC

[GitHub] [qpid-dispatch] bhardesty commented on a change in pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…

bhardesty commented on a change in pull request #578: DISPATCH-1434 - Added new attribute saslPasswordFile to the connector…
URL: https://github.com/apache/qpid-dispatch/pull/578#discussion_r330274380
 
 

 ##########
 File path: python/qpid_dispatch/management/qdrouter.json
 ##########
 @@ -1002,10 +1002,17 @@
                 "saslPassword": {
                     "type": "string",
                     "required": false,
-                    "description": "The password that the connector is using to connect to a peer.",
+                    "description": "(DEPRECATED) The password that the connector is using to connect to a peer.",
                     "create": true,
+                    "deprecated": true,
                     "hidden": true
                 },
+                "saslPasswordFile": {
+                    "type": "string",
+                    "required": false,
+                    "description": "The full path to the file that contains the password that the connector uses to connect to a peer.",
 
 Review comment:
   Instead of "full path", use "absolute path".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org