[GitHub] [netbeans] JaroslavTulach commented on pull request #2467: Read "exec.mainClass" property from POM file, before asking for the main class.

[GitBox <gi...@apache.org>]

JaroslavTulach commented on pull request #2467:
URL: https://github.com/apache/netbeans/pull/2467#issuecomment-711128357


   Is `exec.mainClass` a standardized Maven property? I guess [it is](https://www.mojohaus.org/exec-maven-plugin/usage.html).
   
   However I am not sure this kind of property reading covers all the possible cases. For example the "source level" as obtained in `MavenSourceLevelImpl` is trying to get the actual plugin parameters, not just global `pom.xml` the property. 
   
   I know many projects that configure the [main class differently](https://github.com/jtulach/minesweeper/blob/master/client/pom.xml#L99). How does the `exec` configuration looks in your case?
   
   Should we go with this simplistic approach, then at least please enhance the `RunJarPrereqCheckerTest` to cover your case. If we rewrite the main-class locating, we want to be sure this use-case stays supported.
   
   One additional (diverging) idea: if there is just a single main class in the project, then the selection dialog could automatically select it (at least in the headless mode).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists