You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Andy Seaborne (Jira)" <ji...@apache.org> on 2023/01/01 22:10:00 UTC

[jira] [Comment Edited] (FILEUPLOAD-309) Release version 2.0.0

    [ https://issues.apache.org/jira/browse/FILEUPLOAD-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652022#comment-17652022 ] 

Andy Seaborne edited comment on FILEUPLOAD-309 at 1/1/23 10:09 PM:
-------------------------------------------------------------------

I tried the servlet 3.1 multipart support.

Our (Jena) usage is
 * a servlet filter
 * deployed in any servlet container - normally bundled with Jetty; some users deploy a WAR file version in Tomcat et al.
 * `multipart/form-data` is just one possible content-type at the URL endpoint.
 * streaming (errors are handled by being inside a database transaction)

Each servlet container needs custom configuration.

`
{{@MultipartConfig}} only applies to servlets, not servlet filters. [https://github.com/jakartaee/servlet/issues/87]

Jetty: the code can set request attribute {{__MULTIPART_CONFIG_ELEMENT}} during request processing.

Tomcat needs a setting of a context XML attribute {{allowCasualMultipartParsing}}. e.g. set it in {{META-INF/context.xml}}. That does at least avoid users needing to specially change the configuration of their server.


was (Author: andy.seaborne):
I tried the servlet 3.1 multipart support.

Our (Jena) usage is
* a servlet filter
* deployed in any servlet container - normally bundled with Jetty; some users deploy a WAR file version in Tomcat et al.
* `multipart/form-data` is just one possible content-type at the URL endpoint.
* streaming (errors are handled by being inside a database transaction)

Each servlet container needs custom configuration. 

`@MultipartConfig` only applies to servlets, not servlet filters. https://github.com/jakartaee/servlet/issues/87

Jetty: the code can set request attribute `__MULTIPART_CONFIG_ELEMENT` during request processing.

Tomcat needs a setting of a context XML attribute `allowCasualMultipartParsing`. Set in e.g. `META-INF/context.xml`.


> Release version 2.0.0
> ---------------------
>
>                 Key: FILEUPLOAD-309
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-309
>             Project: Commons FileUpload
>          Issue Type: Wish
>            Reporter: Thiago Henrique Hupner
>            Priority: Major
>
> At Piranha, we've migrated to use the new Jakarta namespace.
> One of our dependencies is the Commons File Upload, but the latest version available is 1.4.
> Looking around at the source code, I've found that the code is already prepared for the new Jakarta namespace.
> So, I want to know if there's a plan to release a new version soon. Or at least a 2.0.0 milestone.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)