[jira] [Commented] (TS-4328) Connect_retries re-connects even if request made it to origin (TS-3440 repeat)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15229588#comment-15229588 ] 

ASF GitHub Bot commented on TS-4328:
------------------------------------

Github user bgaff commented on the pull request:

    https://github.com/apache/trafficserver/pull/554#issuecomment-206675022
  
    I did the original fix for this bug and this missed case definitely makes sense. I'm :+1: with the fix. The only thing that looks a little weird is using milestones as a flag but I suppose that's probably better than adding an unnecessary boolean flag.


> Connect_retries re-connects even if request made it to origin (TS-3440 repeat)
> ------------------------------------------------------------------------------
>
>                 Key: TS-4328
>                 URL: https://issues.apache.org/jira/browse/TS-4328
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Thomas Jackson
>            Assignee: Thomas Jackson
>
> I'm creating another issue as the root bug for TS-3440 can still be reproduced if the origin is extremely slow (but no returns no error response).
> I've opened a PR (https://github.com/apache/trafficserver/pull/554) which reverts the original patch and instead checks if any bytes where sent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)