You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by ch...@huawei.com on 2011/12/06 17:41:53 UTC

Review Request: Insert overwrite table db.tname fails if partition already exists

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3026/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Insert Overwrite table db.tname fails if partition already exists.
 For example-
 insert overwrite table db.tname PARTITION(part='p') select .. from t2 where part='p'; fails if partition 'p' already exists. 

Internal of the code not consider the database name of the table and it is continued with the default database.

Changed the code like if table contains the database name called the alter partition using the dbname and tablename.


This addresses bug HIVE-2617.
    https://issues.apache.org/jira/browse/HIVE-2617


Diffs
-----

  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1210917 
  trunk/ql/src/test/queries/clientpositive/insert2_overwrite_partitions.q PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/insert2_overwrite_partitions.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/3026/diff


Testing
-------

Added new testcase and all unit tests are passed


Thanks,

chinna