You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/30 19:08:35 UTC
[GitHub] [incubator-superset] harrytruong opened a new pull request #7950:
Add dashboard loading indicator
harrytruong opened a new pull request #7950: Add dashboard loading indicator
URL: https://github.com/apache/incubator-superset/pull/7950
### CATEGORY
Choose one
- [ ] Bug Fix
- [x] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Adds a top-level dashboard loading indicator (originally opened as https://github.com/airbnb/incubator-superset/pull/143)
Today, we show loading indicators overlaying each chart on the dashboard, but we don't show a top-level indicator for the full dashboard. This is problematic because the loading indicators are sometimes easy to miss (e.g., loading is happening in other dashboard sub-tabs, or loading indicator on chart has low-contrast).
**Additional Background**:
I use Superset heavily (on the Airbnb Human Team), and have been working with non-engs that use these dashboards frequently. I keep getting feedback on different perf-related issues, and I feel like it's eroding their trust in the data.
I'm throwing up this "central" loading indicator to make it clearer that no more "loading" is taking place on the dashboard, so they can hopefully have more confidence that the numbers are "ready". (Before this, they would toggle dashboard filters, and the chart-by-chart loading indicators would cause them to feel unsure whether the data is ready to be interpreted.)
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Dashboard while loading | Dashboard after loading finishes
--- | ---
<img width="1514" alt="Screen Shot 2019-07-18 at 11 17 30 AM" src="https://user-images.githubusercontent.com/490393/61482051-97c00d80-a94e-11e9-84d0-90e176977d1f.png"> | <img width="1506" alt="Screen Shot 2019-07-18 at 11 17 49 AM" src="https://user-images.githubusercontent.com/490393/61482062-9b539480-a94e-11e9-9a2e-98992bed1518.png">
### TEST PLAN
Followed CONTRIBUTING.md docs, set up local Superset instance and confirmed changes locally.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
@etr2460
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org