You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "FangYongs (via GitHub)" <gi...@apache.org> on 2023/11/01 08:15:38 UTC

[PR] [core] Add convert properties with prefix key in OptionsUtils [incubator-paimon]

FangYongs opened a new pull request, #2230:
URL: https://github.com/apache/incubator-paimon/pull/2230

   ### Purpose
   
   Linked issue: close #2229 
   
   Add convert properties with prefix key in OptionsUtils
   
   ### Tests
   
   This feature is covered by existing tests
   
   ### API and Format
   
   no
   
   ### Documentation
   
   no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Add convert properties with prefix key in OptionsUtils [incubator-paimon]

Posted by "zhuangchong (via GitHub)" <gi...@apache.org>.
zhuangchong merged PR #2230:
URL: https://github.com/apache/incubator-paimon/pull/2230


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [core] Add convert properties with prefix key in OptionsUtils [incubator-paimon]

Posted by "liming30 (via GitHub)" <gi...@apache.org>.
liming30 commented on code in PR #2230:
URL: https://github.com/apache/incubator-paimon/pull/2230#discussion_r1383224776


##########
paimon-common/src/main/java/org/apache/paimon/options/OptionsUtils.java:
##########
@@ -291,6 +297,23 @@ static Map<String, String> convertToPropertiesPrefixed(
                                 k -> convertToString(confData.get(k))));
     }
 
+    public static Map<String, String> convertToPropertiesPrefixKey(
+            Iterable<Map.Entry<String, String>> confData,
+            final String prefixKey,
+            Function<String, Boolean> valuePredicate) {

Review Comment:
   Maybe we can use `java.util.function.Predicate`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org