You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/24 16:05:00 UTC
[jira] [Commented] (ARTEMIS-1633) ActiveMQServerPlugin message
routing callbacks should fire for all results
[ https://issues.apache.org/jira/browse/ARTEMIS-1633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337813#comment-16337813 ]
ASF GitHub Bot commented on ARTEMIS-1633:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1816
ARTEMIS-1633 - fire message routing callbacks for all results
Make sure ActiveMQServer plugin implementations are always notified of
message route events
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1633
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1816.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1816
----
commit 713c48fd26ce6577b870845ea883b2d90e5915b5
Author: Christopher L. Shannon (cshannon) <ch...@...>
Date: 2018-01-24T16:03:12Z
ARTEMIS-1633 - fire message routing callbacks for all results
Make sure ActiveMQServer plugin implementations are always notified of
message route events
----
> ActiveMQServerPlugin message routing callbacks should fire for all results
> --------------------------------------------------------------------------
>
> Key: ARTEMIS-1633
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1633
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.4.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Priority: Major
> Fix For: 2.5.0
>
>
> When I added the callbacks for beforeMessageRoute and afterMessageRoute I accidentally inserted them so that they will only be called when the RoutingStatus result is OK. They should always be called even if the status is no bindings, or no bindings DLA, etc to allow the plugin writer to handle events depending on the routing status.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)